Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s…

chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index d904e23fe206c64acaa22733c9e444c9fee23f93..18afaab162a4bd1f5a014d4864dad5313fa309aa 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -10,6 +10,7 @@
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/passwords/password_bubble_experiment.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "ui/base/l10n/l10n_util.h"
@@ -34,12 +35,17 @@ int GetFieldWidth(FieldType type) {
                                                    : kPasswordFieldSize);
 }
 
+Profile* GetProfileFromWebContents(content::WebContents* web_contents) {
+  if (!web_contents)
+    return nullptr;
+  return Profile::FromBrowserContext(web_contents->GetBrowserContext());
+}
+
 void RecordExperimentStatistics(content::WebContents* web_contents,
                                 metrics_util::UIDismissalReason reason) {
-  if (!web_contents)
+  Profile* profile = GetProfileFromWebContents(web_contents);
+  if (!profile)
     return;
-  Profile* profile =
-      Profile::FromBrowserContext(web_contents->GetBrowserContext());
   password_bubble_experiment::RecordBubbleClosed(profile->GetPrefs(), reason);
 }
 
@@ -50,6 +56,15 @@ base::string16 PendingStateTitleBasedOnSavePasswordPref(
                            : IDS_SAVE_PASSWORD);
 }
 
+void RecordURLSCollectionExperimentStatistics(
+    content::WebContents* web_contents) {
+  Profile* profile = GetProfileFromWebContents(web_contents);
+  if (!profile)
+    return;
+  password_manager::urls_collection_experiment::RecordBubbleClosed(

[vabr (Chromium), 2014/12/08 11:19:33]

It looks like this is called when the bubble is open. Do I misunderstand
something?

[melandory, 2014/12/08 13:05:31]

Done.

Yep, you are right. There was reason why it was called before creating a bubble,
but now it's gone.

+      profile->GetPrefs());
+}
+
 }  // namespace
 
 ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
@@ -80,6 +95,7 @@ ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
   } else if (password_manager::ui::IsCredentialsState(state_)) {
     title_ = l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_CHOOSE_TITLE);
   } else if (password_manager::ui::IsAskSubmitURLState(state_)) {
+    RecordURLSCollectionExperimentStatistics(web_contents);
     title_ =
         l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_ASK_TO_SUBMIT_URL_TITLE);
   } else {