Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s…

chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/passwords/password_bubble_experiment.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using autofill::PasswordFormMap;
 using content::WebContents;
 namespace metrics_util = password_manager::metrics_util;
 
 namespace {
 
 enum FieldType { USERNAME_FIELD, PASSWORD_FIELD };
 
 const int kUsernameFieldSize = 30;
 const int kPasswordFieldSize = 22;
 
 // Returns the width of |type| field.
 int GetFieldWidth(FieldType type) {
   return ui::ResourceBundle::GetSharedInstance()
       .GetFontList(ui::ResourceBundle::SmallFont)
       .GetExpectedTextWidth(type == USERNAME_FIELD ? kUsernameFieldSize
                                                    : kPasswordFieldSize);
 }
 
+Profile* GetProfileFromWebContents(content::WebContents* web_contents) {
+  if (!web_contents)
+    return nullptr;
+  return Profile::FromBrowserContext(web_contents->GetBrowserContext());
+}
+
 void RecordExperimentStatistics(content::WebContents* web_contents,
                                 metrics_util::UIDismissalReason reason) {
-  if (!web_contents)
+  Profile* profile = GetProfileFromWebContents(web_contents);
+  if (!profile)
     return;
-  Profile* profile =
-      Profile::FromBrowserContext(web_contents->GetBrowserContext());
   password_bubble_experiment::RecordBubbleClosed(profile->GetPrefs(), reason);
 }
 
 base::string16 PendingStateTitleBasedOnSavePasswordPref(
     bool never_save_passwords) {
   return l10n_util::GetStringUTF16(
       never_save_passwords ? IDS_MANAGE_PASSWORDS_BLACKLIST_CONFIRMATION_TITLE
                            : IDS_SAVE_PASSWORD);
 }
 
+void RecordURLSCollectionExperimentStatistics(
+    content::WebContents* web_contents) {
+  Profile* profile = GetProfileFromWebContents(web_contents);
+  if (!profile)
+    return;
+  password_manager::urls_collection_experiment::RecordBubbleClosed(

[vabr (Chromium), 2014/12/08 11:19:33]

It looks like this is called when the bubble is open. Do I misunderstand
something?

[melandory, 2014/12/08 13:05:31]

Done.

Yep, you are right. There was reason why it was called before creating a bubble,
but now it's gone.

+      profile->GetPrefs());
+}
+
 }  // namespace
 
 ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
     content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       never_save_passwords_(false),
       display_disposition_(metrics_util::AUTOMATIC_WITH_PASSWORD_PENDING),
       dismissal_reason_(metrics_util::NOT_DISPLAYED) {
   ManagePasswordsUIController* controller =
       ManagePasswordsUIController::FromWebContents(web_contents);
@@ skipping 10 matching lines @@
   if (password_manager::ui::IsPendingState(state_)) {
     title_ = PendingStateTitleBasedOnSavePasswordPref(never_save_passwords_);
   } else if (state_ == password_manager::ui::BLACKLIST_STATE) {
     title_ = l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_BLACKLISTED_TITLE);
   } else if (state_ == password_manager::ui::CONFIRMATION_STATE) {
     title_ =
         l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_TITLE);
   } else if (password_manager::ui::IsCredentialsState(state_)) {
     title_ = l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_CHOOSE_TITLE);
   } else if (password_manager::ui::IsAskSubmitURLState(state_)) {
+    RecordURLSCollectionExperimentStatistics(web_contents);
     title_ =
         l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_ASK_TO_SUBMIT_URL_TITLE);
   } else {
     title_ = l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_TITLE);
   }
 
   base::string16 save_confirmation_link =
       l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_LINK);
   size_t offset;
   save_confirmation_text_ =
@@ skipping 166 matching lines @@
 
 // static
 int ManagePasswordsBubbleModel::UsernameFieldWidth() {
   return GetFieldWidth(USERNAME_FIELD);
 }
 
 // static
 int ManagePasswordsBubbleModel::PasswordFieldWidth() {
   return GetFieldWidth(PASSWORD_FIELD);
 }