Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc

Issue 777423004: Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc b/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
index 12a4c04f811969e16fc26977fccbe616ea3d133d..23cad231b5a6d6eed99f023f2dbed91ef473f788 100644
--- a/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
@@ -5,14 +5,20 @@
#include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
#include "base/files/scoped_temp_dir.h"
+#include "base/prefs/pref_registry_simple.h"
#include "base/prefs/pref_service.h"
#include "base/prefs/testing_pref_service.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/variations/entropy_provider.h"
#include "testing/gtest/include/gtest/gtest.h"
-namespace {
-
class PasswordManagerUrlsCollectionExperimentTest : public testing::Test {
public:
+ void SetUp() override {
+ pref_service_.registry()->RegisterBooleanPref(
+ password_manager::prefs::kWasAllowToCollectURLBubbleShown, false);
+ }
+
PrefService* prefs() { return &pref_service_; }
private:
@@ -24,4 +30,22 @@ TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestDefault) {
password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
}
-} // namespace
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestMaybeShowBubbleGroup) {
+ // TODO(melandory) This test case should be rewritten when decision about
+ // should bubble be shown or not will be made based on Finch experiment
+ // http://crbug.com/435080.
+ EXPECT_FALSE(
+ password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}
+
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestNeverShowBubbleGroup) {
+ EXPECT_FALSE(
+ password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}
+
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestBubbleWasAlreadyShown) {
+ prefs()->SetBoolean(password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+ true);
+ EXPECT_FALSE(
+ password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}

Powered by Google App Engine
This is Rietveld 408576698