Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: components/password_manager/core/browser/password_manager_url_collection_experiment.cc

Issue 777423004: Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_url_collection_experiment.cc
diff --git a/components/password_manager/core/browser/password_manager_url_collection_experiment.cc b/components/password_manager/core/browser/password_manager_url_collection_experiment.cc
index b8d66c5e87d38d9a328cc0c149cd260f379546f6..61c2b85e69bd3997dd8db9afabcf379b1c221fc7 100644
--- a/components/password_manager/core/browser/password_manager_url_collection_experiment.cc
+++ b/components/password_manager/core/browser/password_manager_url_collection_experiment.cc
@@ -2,17 +2,45 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/prefs/pref_service.h"
#include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
+#include "base/prefs/pref_service.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+
namespace password_manager {
namespace urls_collection_experiment {
+namespace {
+
+bool ShouldShowBubbleExperiment(PrefService* prefs) {
+ // TODO(melandory): Make decision based on Finch experiment parameters.
+ return false;
+}
+
+} // namespace
+
+void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) {
+ registry->RegisterBooleanPref(
+ password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+ false, // bubble hasn't been shown yet
+ user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+}
+
+const char kExperimentName[] = "AskToSubmitURLBubble";
+
bool ShouldShowBubble(PrefService* prefs) {
- // TODO(melandory) Make descision based on Finch experiment.
+ if (prefs->GetBoolean(prefs::kWasAllowToCollectURLBubbleShown)) {
+ return ShouldShowBubbleExperiment(prefs);
+ }
// "Do not show" is the default case.
return false;
}
+void RecordBubbleClosed(PrefService* prefs) {
+ prefs->SetBoolean(password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+ true);
+}
+
} // namespace urls_collection_experiment
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698