Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s…

components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc

Index: components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc b/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
index 12a4c04f811969e16fc26977fccbe616ea3d133d..0d5b9844c4b2fdbd9242d5d9a6901a7f2b2d2903 100644
--- a/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_url_collection_experiment_unittest.cc
@@ -5,18 +5,45 @@
 #include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
 
 #include "base/files/scoped_temp_dir.h"
+#include "base/metrics/field_trial.h"
+#include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/variations/entropy_provider.h"
+#include "components/variations/variations_associated_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
+void SetupMaybeShowBubbleExperimentGroup() {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      password_manager::urls_collection_experiment::kExperimentName,
+      password_manager::urls_collection_experiment::kGroupMaybeShowBubble));
+}
+
+void SetupNeverShowBubbleExperimentGroup() {
+  ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
+      password_manager::urls_collection_experiment::kExperimentName,
+      password_manager::urls_collection_experiment::kGroupNeverShowBubble));
+}
+
+}  // namespace
+
 class PasswordManagerUrlsCollectionExperimentTest : public testing::Test {
  public:
+  PasswordManagerUrlsCollectionExperimentTest()
+      : field_trial_list_(new metrics::SHA1EntropyProvider("foo")) {}

[vabr (Chromium), 2014/12/08 13:17:20]

nit: One blank line after line 36, please. :)

[melandory, 2014/12/09 23:52:35]

Done.

+  void SetUp() override {
+    pref_service_.registry()->RegisterBooleanPref(
+        password_manager::prefs::kWasAllowToCollectURLBubbleShown, false);
+  }
+
   PrefService* prefs() { return &pref_service_; }
 
  private:
   TestingPrefServiceSimple pref_service_;
+  base::FieldTrialList field_trial_list_;
 };
 
 TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestDefault) {
@@ -24,4 +51,25 @@ TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestDefault) {
       password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
 }
 
-}  // namespace
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestMaybeShowBubbleGroup) {
+  SetupMaybeShowBubbleExperimentGroup();
+  // TODO(melandory) This test case should be rewritten when decision about
+  // should bubble be shown or not will be made based on Finch experiment
+  // crbug/435080

[vabr (Chromium), 2014/12/08 13:17:20]

nits:
(1) Please include a full-stop at the end of the sentence.
(2) If you write http://crbug.com/435080, as opposed to just crbug/435080, it
will become clickable in the CodeSearch.

[melandory, 2014/12/09 23:52:35]

Done.

+  EXPECT_FALSE(
+      password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}
+
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestNeverShowBubbleGroup) {
+  SetupNeverShowBubbleExperimentGroup();
+  EXPECT_FALSE(
+      password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}
+
+TEST_F(PasswordManagerUrlsCollectionExperimentTest, TestBubbleWasAlreadyShown) {
+  SetupMaybeShowBubbleExperimentGroup();
+  prefs()->SetBoolean(password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+                      true);
+  EXPECT_FALSE(
+      password_manager::urls_collection_experiment::ShouldShowBubble(prefs()));
+}