Skeleton code for experiment setup, which will determine should "Allow to collect URL?" bubble be s…

components/password_manager/core/browser/password_manager_url_collection_experiment.cc

Index: components/password_manager/core/browser/password_manager_url_collection_experiment.cc
diff --git a/components/password_manager/core/browser/password_manager_url_collection_experiment.cc b/components/password_manager/core/browser/password_manager_url_collection_experiment.cc
index b8d66c5e87d38d9a328cc0c149cd260f379546f6..581b9f4e2f9e29baa2ef410c2ca76377ba436f89 100644
--- a/components/password_manager/core/browser/password_manager_url_collection_experiment.cc
+++ b/components/password_manager/core/browser/password_manager_url_collection_experiment.cc
@@ -2,17 +2,53 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/prefs/pref_service.h"
 #include "components/password_manager/core/browser/password_manager_url_collection_experiment.h"
 
+#include "base/metrics/field_trial.h"
+#include "base/prefs/pref_service.h"
+#include "components/password_manager/core/common/password_manager_pref_names.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+
 namespace password_manager {
 namespace urls_collection_experiment {
 
+namespace {
+
+bool MaybeShowBubbleExperiment(PrefService* prefs) {

[battre, 2014/12/09 11:02:16]

Can you come up with a name that does not start with Maybe? Is there a precedent
for this? I find it difficult to understand what this function would do as
"Maybe" is not a verb.

[vabr (Chromium), 2014/12/09 11:34:05]

This is not that uncommon, quick codesearch, e.g., [void\ Maybe], reveals 200+
occurences. A random hand-picked example is MaybeGenerateAuthToken of
/net/http/http_auth_controller.h.
It is generally used in the form MaybeDoStuff, where DoStuff may not be carried
out for all input conditions.

[melandory, 2014/12/09 23:52:35]

Done.

+  // TODO(melandory): Make decision based on Finch experiment parameters.
+  return false;
+}
+
+}  // namespace
+
+void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) {
+  registry->RegisterBooleanPref(
+      password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+      false,  // bubble hasn't been shown yet
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+}
+
+const char kExperimentName[] = "AskToSubmitURLBubble";
+const char kGroupMaybeShowBubble[] = "ShowBubble";
+const char kGroupNeverShowBubble[] = "NeverShowBubble";
+
 bool ShouldShowBubble(PrefService* prefs) {
-  // TODO(melandory) Make descision based on Finch experiment.
+  if (prefs->GetBoolean(prefs::kWasAllowToCollectURLBubbleShown)) {
+    if (!base::FieldTrialList::TrialExists(kExperimentName))
+      return false;
+    std::string group_name =
+        base::FieldTrialList::FindFullName(kExperimentName);
+    if (group_name == kGroupMaybeShowBubble)
+      return MaybeShowBubbleExperiment(prefs);
+  }
   // "Do not show" is the default case.
   return false;
 }
 
+void RecordBubbleClosed(PrefService* prefs) {
+  prefs->SetBoolean(password_manager::prefs::kWasAllowToCollectURLBubbleShown,
+                    true);
+}
+
 }  // namespace urls_collection_experiment
 }  // namespace password_manager