perf/go/activitylog/activitylog.go - Issue 777413002: Add new tests to presubmit, fix errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: perf/go/activitylog/activitylog.go

Issue 777413002: Add new tests to presubmit, fix errors (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: perf/go/activitylog/activitylog.go

diff --git a/perf/go/activitylog/activitylog.go b/perf/go/activitylog/activitylog.go

index a850942759581a86694ab1add77594b9de546c74..ad69e4cc6db4b75956e82b37e9da7ee0d8f94d00 100644

--- a/perf/go/activitylog/activitylog.go

+++ b/perf/go/activitylog/activitylog.go

@@ -17,7 +17,7 @@ import (

func Write(r *types.Activity) error {

glog.Infof("Write activity: %s\n", r)

if r.UserID == "" || r.Action == "" {

- return fmt.Errorf("Activity UserID and Action cannot be empty: %s\n", r)

+ return fmt.Errorf("Activity UserID and Action cannot be empty: %v\n", r)

}

_, err := db.DB.Exec(

"INSERT INTO activitylog (timestamp, userid, action, url) VALUES (?, ?, ?, ?)",

« no previous file with comments | « monitoring/go/prober/main.go ('k') | perf/go/alerting/alerting.go » ('j') | no next file with comments »