perf/go/alerting/alerting.go - Issue 777413002: Add new tests to presubmit, fix errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: perf/go/alerting/alerting.go

Issue 777413002: Add new tests to presubmit, fix errors (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: perf/go/alerting/alerting.go

diff --git a/perf/go/alerting/alerting.go b/perf/go/alerting/alerting.go

index 4ea881a9c4b24689ef6c199868b43f54b585f248..3211b9d01f674040e01519078bce840227206eab 100644

--- a/perf/go/alerting/alerting.go

+++ b/perf/go/alerting/alerting.go

@@ -135,7 +135,7 @@ func processRows(rows *sql.Rows, err error) ([]*types.ClusterSummary, error) {

}

c := &types.ClusterSummary{}

if err := json.Unmarshal([]byte(body), c); err != nil {

- glog.Errorf("Found invalid JSON in clusters table: %s %s", id, err)

+ glog.Errorf("Found invalid JSON in clusters table: %d %s", id, err)

return nil, fmt.Errorf("Failed to read row from database: %s", err)

}

c.ID = id

« no previous file with comments | « perf/go/activitylog/activitylog.go ('k') | perf/go/filetilestore/filestore.go » ('j') | no next file with comments »