[WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

content/child/webcrypto/status.cc

Index: content/child/webcrypto/status.cc
diff --git a/content/child/webcrypto/status.cc b/content/child/webcrypto/status.cc
index 03e506fb00d28804468296892655c903928a7059..044d2e85b3cb319427810a69d54927d801dbe315 100644
--- a/content/child/webcrypto/status.cc
+++ b/content/child/webcrypto/status.cc
@@ -268,9 +268,9 @@ Status Status::ErrorCreateKeyBadUsages() {
                 "Cannot create a key using the specified key usages.");
 }
 
-Status Status::ErrorCreateKeyEmptyUsages() {
+Status Status::ErrorKeyEmptyUsages() {

[eroman, 2014/12/16 01:26:45]

Several issues here:
  (1) The header was not updated to remove ErrorCreateKeyEmptyUsages(), however
it's definition was removed.

  (2) I don't see the need for changing the method name or error text. "Creating
a key" seems like a good general name for both generating and importing (both
are ways of creating a key).

Please leave this unchanged. If you want to propose different text for the error
do so in a separate changelist.

[Habib Virji, 2014/12/16 09:59:42]

I have updated header and removed new function previously added.

   return Status(blink::WebCryptoErrorTypeSyntax,
-                "Usages cannot be empty when creating a key.");
+                "Usages cannot be empty for creating or importing keys.");
 }
 
 Status Status::ErrorImportedEcKeyIncorrectCurve() {