[WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

content/child/webcrypto/status.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/webcrypto/status.h"
 
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
 
 namespace content {
@@ skipping 250 matching lines @@
       blink::WebCryptoErrorTypeData,
       "The optional HMAC key length must be shorter than the key data, and by "
       "no more than 7 bits.");
 }
 
 Status Status::ErrorCreateKeyBadUsages() {
   return Status(blink::WebCryptoErrorTypeSyntax,
                 "Cannot create a key using the specified key usages.");
 }
 
-Status Status::ErrorCreateKeyEmptyUsages() {
+Status Status::ErrorKeyEmptyUsages() {

[eroman, 2014/12/16 01:26:45]

Several issues here:
  (1) The header was not updated to remove ErrorCreateKeyEmptyUsages(), however
it's definition was removed.

  (2) I don't see the need for changing the method name or error text. "Creating
a key" seems like a good general name for both generating and importing (both
are ways of creating a key).

Please leave this unchanged. If you want to propose different text for the error
do so in a separate changelist.

[Habib Virji, 2014/12/16 09:59:42]

I have updated header and removed new function previously added.

   return Status(blink::WebCryptoErrorTypeSyntax,
-                "Usages cannot be empty when creating a key.");
+                "Usages cannot be empty for creating or importing keys.");
 }
 
 Status Status::ErrorImportedEcKeyIncorrectCurve() {
   return Status(
       blink::WebCryptoErrorTypeData,
       "The imported EC key specifies a different curve than requested");
 }
 
 Status Status::ErrorJwkIncorrectCrv() {
   return Status(
@@ skipping 49 matching lines @@
       error_type_(error_type),
       error_details_(error_details_utf8) {
 }
 
 Status::Status(Type type) : type_(type) {
 }
 
 }  // namespace webcrypto
 
 }  // namespace content