Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1644)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/child/webcrypto/status.h

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per code review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/child/webcrypto/openssl/ec_key_openssl.cc ('K') | « content/child/webcrypto/openssl/sym_key_openssl.cc ('k') | content/child/webcrypto/test/aes_cbc_unittest.cc » ('j') | content/child/webcrypto/test/rsa_ssa_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/status.h
diff --git a/content/child/webcrypto/status.h b/content/child/webcrypto/status.h
index 05f0f4eac23c0a975adb6149e696ec9a8a280a8e..aeaa8a02d7ffd6d387a057895f5aaaa833dc4bb4 100644
--- a/content/child/webcrypto/status.h
+++ b/content/child/webcrypto/status.h
@@ -225,7 +225,7 @@ class CONTENT_EXPORT Status {
// and algorithm.
static Status ErrorCreateKeyBadUsages();
- // No usages were specified when creating a secret or private key.
+ // No usages were specified when creating/importing a secret or private key.
eroman 2014/12/17 01:23:51 creating/importing --> generating/importing
Habib Virji 2014/12/17 15:41:53 Done.
static Status ErrorCreateKeyEmptyUsages();
// An EC key imported using SPKI/PKCS8 format had the wrong curve specified in
« content/child/webcrypto/openssl/ec_key_openssl.cc ('K') | « content/child/webcrypto/openssl/sym_key_openssl.cc ('k') | content/child/webcrypto/test/aes_cbc_unittest.cc » ('j') | content/child/webcrypto/test/rsa_ssa_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698