content/child/webcrypto/openssl/ec_key_openssl.cc - Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/openssl/ec_key_openssl.cc

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per code review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/webcrypto/openssl/aes_key_openssl.cc ('k') | content/child/webcrypto/openssl/hmac_openssl.cc » ('j') | content/child/webcrypto/status.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/webcrypto/openssl/ec_key_openssl.cc

diff --git a/content/child/webcrypto/openssl/ec_key_openssl.cc b/content/child/webcrypto/openssl/ec_key_openssl.cc

index faba7f8f634e54703c460665b9a760b2ea7a6a61..0a7cb5537b026b8b3797fa23d15f97dea3ea03cb 100644

--- a/content/child/webcrypto/openssl/ec_key_openssl.cc

+++ b/content/child/webcrypto/openssl/ec_key_openssl.cc

@@ -374,7 +374,7 @@ Status EcAlgorithm::ImportKeyJwk(const CryptoData& key_data,

// Now that the key type is known, verify the usages.

status = CheckKeyCreationUsages(

is_private_key ? all_private_key_usages_ : all_public_key_usages_,

- usages);

+ usages, true);

eroman 2014/12/17 01:23:51 I don't believe this is correct. Shouldn't it be !

Habib Virji 2014/12/17 15:41:53 Sorry I missed this file to update. You were rig

if (status.IsError())

return status;

« no previous file with comments | « content/child/webcrypto/openssl/aes_key_openssl.cc ('k') | content/child/webcrypto/openssl/hmac_openssl.cc » ('j') | content/child/webcrypto/status.h » ('J')