[WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

content/child/webcrypto/openssl/ec_key_openssl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/webcrypto/openssl/ec_key_openssl.h"
 
 #include <openssl/ec.h>
 #include <openssl/ec_key.h>
 #include <openssl/evp.h>
 #include <openssl/pkcs12.h>
@@ skipping 356 matching lines @@
   if (jwk_crv != params->namedCurve())
     return Status::ErrorJwkIncorrectCrv();
 
   // Only private keys have a "d" parameter. The key may still be invalid, but
   // tentatively decide if it is a public or private key.
   bool is_private_key = jwk.HasMember("d");
 
   // Now that the key type is known, verify the usages.
   status = CheckKeyCreationUsages(
       is_private_key ? all_private_key_usages_ : all_public_key_usages_,
-      usages);
+      usages, true);

[eroman, 2014/12/17 01:23:51]

I don't believe this is correct. Shouldn't it be !is_private_key ?

I see that you have added unit-tests for this scenario, do those tests pass? Is
it possible you are running in an environment without ECDH support and hence
those tests you added were not run?

[Habib Virji, 2014/12/17 15:41:53]

Sorry I missed this file to update. 

You were right regarding my environment. Since I am running on Linux it was not
running ecdh and thus this was not invisible. I have now checked by changing
with build using boringSSL, it does run fine.

   if (status.IsError())
     return status;
 
   // Create an EC_KEY.
   crypto::ScopedEC_KEY ec;
   status = CreateEC_KEY(params->namedCurve(), &ec);
   if (status.IsError())
     return status;
 
   // JWK requires the length of x, y, d to match the group degree.
@@ skipping 163 matching lines @@
       key->algorithm().ecParams()->namedCurve()) {
     return Status::ErrorUnexpected();
   }
 
   return Status::Success();
 }
 
 }  // namespace webcrypto
 
 }  // namespace content