content/child/webcrypto/nss/hmac_nss.cc - Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/nss/hmac_nss.cc

Issue 777403004: [WebCrypto] Throw syntaxError if keyUsage is empty in ImportKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per code review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/webcrypto/nss/aes_key_nss.cc ('k') | content/child/webcrypto/nss/rsa_key_nss.cc » ('j') | content/child/webcrypto/openssl/ec_key_openssl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/webcrypto/nss/hmac_nss.cc

diff --git a/content/child/webcrypto/nss/hmac_nss.cc b/content/child/webcrypto/nss/hmac_nss.cc

index 89e208666f97715077ace1b16fc9bc3d9c819711..570f8c8d7dc5964291b7606d69d2dbc4baf25edb 100644

--- a/content/child/webcrypto/nss/hmac_nss.cc

+++ b/content/child/webcrypto/nss/hmac_nss.cc

@@ -58,7 +58,7 @@ class HmacImplementation : public AlgorithmImplementation {

bool extractable,

blink::WebCryptoKeyUsageMask usages,

GenerateKeyResult* result) const override {

- Status status = CheckKeyCreationUsages(kAllKeyUsages, usages);

+ Status status = CheckKeyCreationUsages(kAllKeyUsages, usages, false);

if (status.IsError())

return status;

@@ -86,7 +86,7 @@ class HmacImplementation : public AlgorithmImplementation {

switch (format) {

case blink::WebCryptoKeyFormatRaw:

case blink::WebCryptoKeyFormatJwk:

- return CheckKeyCreationUsages(kAllKeyUsages, usages);

+ return CheckKeyCreationUsages(kAllKeyUsages, usages, false);

default:

return Status::ErrorUnsupportedImportKeyFormat();

}