chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alexei & peter nits Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/sync_setup_handler.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index ab7b8f1ac9b1d3fced21329476d4581460f3aa55..c115a4d58df9142457e3b9f95aaea516e5c0b95a 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -276,10 +276,7 @@ void InlineLoginHandlerImpl::SetExtraInitParams(base::DictionaryValue& params) {

net::GetValueForKeyInQuery(current_url, "constrained", &is_constrained);

content::WebContentsObserver::Observe(contents);

- signin::Source source = signin::GetSourceForPromoURL(current_url);

- OneClickSigninHelper::LogHistogramValue(

- source, one_click_signin::HISTOGRAM_SHOWN);

+ OneClickSigninHelper::LogHistogramValue(one_click_signin::HISTOGRAM_SHOWN);

}

void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {

@@ -336,12 +333,10 @@ void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {

dict->GetBoolean("chooseWhatToSync", &choose_what_to_sync);

signin::Source source = signin::GetSourceForPromoURL(current_url);

- OneClickSigninHelper::LogHistogramValue(

- source, one_click_signin::HISTOGRAM_ACCEPTED);

+ OneClickSigninHelper::LogHistogramValue(one_click_signin::HISTOGRAM_ACCEPTED);

bool switch_to_advanced =

choose_what_to_sync && (source != signin::SOURCE_SETTINGS);

OneClickSigninHelper::LogHistogramValue(

- source,

switch_to_advanced ? one_click_signin::HISTOGRAM_WITH_ADVANCED :

one_click_signin::HISTOGRAM_WITH_DEFAULTS);