Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: alexei & peter nits Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc
index d541af5ed770500ca6a61cc4065eadf157111650..66d18d2e3dd4a754df47ae5c7ef4e177b6acd6b2 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc
@@ -382,6 +382,7 @@ void SyncSetupHandler::DisplayGaiaLoginInNewTabOrWindow() {
error_controller->error_account_id());
}
} else {
+ ProfileMetrics::LogSigninSource(signin::SOURCE_SETTINGS);
if (switches::IsNewAvatarMenu() && !force_new_tab) {
browser->window()->ShowAvatarBubbleFromAvatarButton(
BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN,

Powered by Google App Engine
This is Rietveld 408576698