Add frame_tree_node_id to navigation parameters.

Add frame_tree_node_id to navigation parameters.

This will be used to support cross-process subframe navigations.

BUG=314791
TEST=No visible behavior change.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236431

[Charlie Reis, 2013-11-20 17:41:55]

Another piece to land from the RFHM CL.  We don't set it to anything but -1 for
now, but it makes it possible to get the frame tree node ID from
RequestTransferURL to NavigateToEntry.

[nasko, 2013-11-20 18:01:29]

There is only one thing that I'm not sure about, otherwise this is great!

https://codereview.chromium.org/77673003/diff/1/content/browser/frame_host/na...
File content/browser/frame_host/navigation_entry_impl.h (right):

https://codereview.chromium.org/77673003/diff/1/content/browser/frame_host/na...
content/browser/frame_host/navigation_entry_impl.h:336: // not persisted because
it is experimental and only used when the
Before we get to FrameNavigationEntry, what would this value be subframes in a
document? AUTO_SUBFRAME navigations just pile onto the same NavigationEntry, so
do we just drop those ids for the time being?

https://codereview.chromium.org/77673003/diff/1/content/public/browser/page_n...
File content/public/browser/page_navigator.h (right):

https://codereview.chromium.org/77673003/diff/1/content/public/browser/page_n...
content/public/browser/page_navigator.h:35: int64 source_frame_id,
nit: TODO to remove this?

[Charlie Reis, 2013-11-20 21:43:05]

Thanks!  PTAL.

https://codereview.chromium.org/77673003/diff/1/content/browser/frame_host/na...
File content/browser/frame_host/navigation_entry_impl.h (right):

https://codereview.chromium.org/77673003/diff/1/content/browser/frame_host/na...
content/browser/frame_host/navigation_entry_impl.h:336: // not persisted because
it is experimental and only used when the
On 2013/11/20 18:01:30, nasko wrote:
> Before we get to FrameNavigationEntry, what would this value be subframes in a
> document? AUTO_SUBFRAME navigations just pile onto the same NavigationEntry,
so
> do we just drop those ids for the time being?

Good question.  Without the flag, subframe navigations don't have pending
NavigationEntries, so it's not an issue (always -1).

Once we start creating pending entries for subframes behind the flag, the
pending entry exists but gets thrown away in RendererDidNavigateSubframe, so the
last committed NavigationEntry isn't affected and keeps an ID of -1.

That said, I did forget to add it to ResetForCommit, since we don't need the
value after commit.  I've updated that.

https://codereview.chromium.org/77673003/diff/1/content/public/browser/page_n...
File content/public/browser/page_navigator.h (right):

https://codereview.chromium.org/77673003/diff/1/content/public/browser/page_n...
content/public/browser/page_navigator.h:35: int64 source_frame_id,
On 2013/11/20 18:01:30, nasko wrote:
> nit: TODO to remove this?

Wow.  I expected source_frame_id to be needed for something like the Web
Navigation API (etc), but it appears to be dead code.  We pass it in from
WebContents but forget it in browser_navigator.cc.

Before removing it, I want to do some digging to see how much can be removed and
why it was there in the first place, so I've added a TODO.

[nasko, 2013-11-20 22:03:17]

LGTM

[Charlie Reis, 2013-11-20 22:23:16]

sky: Can you take a look at browser/ui/ for owners approval?

[sky, 2013-11-21 00:44:05]

LGTM

[commit-bot: I haz the power, 2013-11-21 02:43:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/77673003/150001

[commit-bot: I haz the power, 2013-11-21 07:10:20]

Change committed as 236431