Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 77673003: Add frame_tree_node_id to navigation parameters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 2d1cb87bed97a3f4bc0d5a01b4934340c136e32f..05c685391a67e294fe153da8b23a69902b0ded00 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1612,6 +1612,8 @@ bool WebContentsImpl::NavigateToEntry(
return false;
}
+ // TODO(creis): Use entry->frame_tree_node_id() to pick which
+ // RenderViewHostManager to use.
RenderViewHostImpl* dest_render_view_host =
static_cast<RenderViewHostImpl*>(GetRenderManager()->Navigate(entry));
if (!dest_render_view_host)
@@ -3141,7 +3143,10 @@ void WebContentsImpl::RequestTransferURL(
GetSiteInstance(), url))
dest_url = GURL(kAboutBlankURL);
- OpenURLParams params(dest_url, referrer, source_frame_id, disposition,
+ // TODO(creis): Look up the FrameTreeNode ID corresponding to source_frame_id.
+ int frame_tree_node_id = -1;
+ OpenURLParams params(dest_url, referrer, source_frame_id,
+ frame_tree_node_id, disposition,
page_transition, true /* is_renderer_initiated */);
if (redirect_chain.size() > 0)
params.redirect_chain = redirect_chain;
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.cc ('k') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698