Use the setting to determine whether showing context menu on mouse up.

Use the setting to determine whether showing context menu on mouse up.

We can use a new web setting[1] instead of macro to detect the platform.
If the setting is true, will be shown context menu on mouse up. (only windows)
If it is false, will be shown on mouse down. (most platforms)

[1] Dependency: https://crrev.com/775553002 (blink side)
[2] Dependency: https://crrev.com/753373006 (chromium side)

BUG=438544
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186483

[zino, 2014-12-02 18:02:15]

jinho.bang@samsung.com changed reviewers:
+ rbyers@chromium.org

[zino, 2014-12-02 18:02:25]

Dear Rick,

Please take a look.

[Rick Byers, 2014-12-02 19:33:07]

Nice, I love removing #ifdefs ;-)

Please add a simple LayoutTest that verifies the two different behaviors.  I.e.
just uses eventSender to send right mouse button down and up twice, once with
your setting disabled and once with it enabled, logging the order of mousedown,
mouseup and contextmenu events.

https://codereview.chromium.org/776483002/diff/1/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (left):

https://codereview.chromium.org/776483002/diff/1/Source/web/WebViewImpl.cpp#o...
Source/web/WebViewImpl.cpp:537: // Dispatch the contextmenu event regardless of
if the click was swallowed.
This comment is still relevant - keep it.

[zino, 2014-12-03 12:24:03]

Patchset #2 (id:20001) has been deleted

[zino, 2014-12-03 12:32:24]

jinho.bang@samsung.com changed reviewers:
+ haraken@chromium.org

[zino, 2014-12-03 12:32:25]

Please take a look.

I added @haraken as reviewer for web/*.

Thank you.

https://codereview.chromium.org/776483002/diff/1/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (left):

https://codereview.chromium.org/776483002/diff/1/Source/web/WebViewImpl.cpp#o...
Source/web/WebViewImpl.cpp:537: // Dispatch the contextmenu event regardless of
if the click was swallowed.
On 2014/12/02 19:33:06, Rick Byers wrote:
> This comment is still relevant - keep it.

Done.

[Rick Byers, 2014-12-03 13:50:20]

LGTM, thanks!

https://codereview.chromium.org/776483002/diff/40001/Source/core/page/EventHa...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/776483002/diff/40001/Source/core/page/EventHa...
Source/core/page/EventHandler.cpp:2833: eventType =
PlatformEvent::MouseReleased;
Note to other reviewers:  I didn't bother asking for a test for this gesture
(touch) case because zino@ is just about to land
https://codereview.chromium.org/727593003/ which includes more thorough testing
that will include this scenario.

[haraken, 2014-12-03 15:11:38]

web/ LGTM

[zino, 2014-12-04 06:31:46]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-12-04 06:32:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/776483002/40001

[commit-bot: I haz the power, 2014-12-04 07:53:49]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186483