Source/core/page/EventHandler.cpp - Issue 776483002: Use the setting to determine whether showing context menu on mouse up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 776483002: Use the setting to determine whether showing context menu on mouse up. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add layout test and exclude modifiers part. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 04050e9e0b6a530eb5039055f8d8913bb4a18cec..09e700fd4b2c4fed7e46d7bc8025a2c8a5e9ba07 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2827,11 +2827,10 @@ bool EventHandler::sendContextMenuEventForKey()

bool EventHandler::sendContextMenuEventForGesture(const GestureEventWithHitTestResults& targetedEvent)

{

-#if OS(WIN)

- PlatformEvent::Type eventType = PlatformEvent::MouseReleased;

-#else

PlatformEvent::Type eventType = PlatformEvent::MousePressed;

-#endif

+ if (m_frame->settings()->showContextMenuOnMouseUp())

+ eventType = PlatformEvent::MouseReleased;

Rick Byers 2014/12/03 13:50:19 Note to other reviewers: I didn't bother asking f

PlatformMouseEvent mouseEvent(targetedEvent.event().position(), targetedEvent.event().globalPosition(), RightButton, eventType, 1, false, false, false, false, PlatformMouseEvent::FromTouch, WTF::currentTime());

// To simulate right-click behavior, we send a right mouse down and then

« no previous file with comments | « LayoutTests/fast/events/show-context-menu-on-mouse-up-expected.txt ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »