Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 776413002: Switch Windows back to NSS. (Closed)

Created:
6 years ago by davidben
Modified:
6 years ago
Reviewers:
brettw, Ryan Sleevi
CC:
chromium-reviews, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch Windows back to NSS. This reverts (the build config portions of) https://codereview.chromium.org/776643003 which switched Windows to BoringSSL from NSS. Apparently there's a problem in Syzygy, and releases are gated on that, so there's not much use in keeping it on trunk in the meantime. R=brettw@chromium.org TBR=rsleevi@chromium.org BUG=338884, 439214 Committed: https://crrev.com/8d7262b218684a4b83421e7eb9a366075718fcaa Cr-Commit-Position: refs/heads/master@{#306928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
TBR rsleevi and brettw. I'll land this when try bots go green.
6 years ago (2014-12-04 22:02:08 UTC) #2
brettw
LGTM, sorry :(
6 years ago (2014-12-04 22:18:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776413002/1
6 years ago (2014-12-04 22:30:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-04 23:23:00 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-04 23:23:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d7262b218684a4b83421e7eb9a366075718fcaa
Cr-Commit-Position: refs/heads/master@{#306928}

Powered by Google App Engine
This is Rietveld 408576698