Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 776643003: Switch Windows over to BoringSSL from NSS. (Closed)

Created:
6 years ago by davidben
Modified:
6 years ago
Reviewers:
brettw, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch Windows over to BoringSSL from NSS. This is a reland of https://crrev.com/306358 which was reverted because it broke the Windows GN build. This is a much much larger change than the diff suggests. If it breaks something, please revert first and ask questions later. BUG=338884 Committed: https://crrev.com/dcbcbd479e2b6effd7bbbb77a01853aa190442ba Cr-Commit-Position: refs/heads/master@{#306659}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M build/common.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +4 lines, -3 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/openssl_platform_key_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davidben
This is TBR'd since it's the same as https://codereview.chromium.org/765603002/ but for BUILD.gn fixes. I won't ...
6 years ago (2014-12-02 23:03:41 UTC) #2
Ryan Sleevi
lgtm
6 years ago (2014-12-03 14:00:38 UTC) #3
brettw
lgtm
6 years ago (2014-12-03 17:45:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776643003/20001
6 years ago (2014-12-03 18:07:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 20:08:54 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-03 20:09:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcbcbd479e2b6effd7bbbb77a01853aa190442ba
Cr-Commit-Position: refs/heads/master@{#306659}

Powered by Google App Engine
This is Rietveld 408576698