Issue 776243005: Revert of move program descriptor generation to flush

Issue 776243005: Revert of move program descriptor generation to flush (Closed)

Created:
6 years ago by joshualitt

Modified:
6 years ago

Reviewers:
egdaniel, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of move program descriptor generation to flush (patchset #7 id:120001 of https://codereview.chromium.org/777673003/) Reason for revert: breaking linux build Original issue's description: > move program descriptor generation to flush > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/829e1b80b1020b17f2078020c990e079b70c077c TBR=egdaniel@google.com,bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f78c60c92a8c212fc462262f2ce81e584d0f02f8

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -121 lines)			Patch
M	src/gpu/GrGpu.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrGpu.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/gpu/GrOptDrawState.h	View	4 chunks	+23 lines, -12 lines	0 comments	Download
M	src/gpu/GrOptDrawState.cpp	View	8 chunks	+53 lines, -55 lines	0 comments	Download
M	src/gpu/GrProgramDesc.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	5 chunks	+13 lines, -10 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLProgramBuilder.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/gpu/gl/builders/GrGLProgramBuilder.cpp	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776243005/1

6 years ago (2014-12-04 14:01:27 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-04 14:01:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f78c60c92a8c212fc462262f2ce81e584d0f02f8