Web Audio: Oilpan: Correctly trace m_referencedNodes elements within a lock.

Web Audio: Oilpan: Correctly trace m_referencedNodes elements within a lock.

Blink r184963 [1] was not a right fix.  Oilpan marker pushed m_referencedNodes
to a stack and released the lock immediately, then iterated it later.
We need to make m_referencedNode HeapVector, not Member<HeapVector>
to iterate it immediately.

[1] http://src.chromium.org/viewvc/blink?view=revision&revision=184963

BUG=434136
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186482

[tkent, 2014-12-04 05:41:16]

tkent@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org, rtoy@chromium.org

[tkent, 2014-12-04 05:41:16]

Please review this.

[haraken, 2014-12-04 05:43:36]

https://codereview.chromium.org/776203002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/776203002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.cpp:1088: }

Shouldn't this be:

if (m_didInitializeContextGraphMutex) {
  AutoLocker lock(this);
  visitor->trace(m_referencedNodes);
} else {
  visitor->trace(m_referencedNodes);
}

?

[tkent, 2014-12-04 05:58:25]

https://codereview.chromium.org/776203002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/776203002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.cpp:1088: }
On 2014/12/04 05:43:35, haraken wrote:
> 
> Shouldn't this be:
> 
> if (m_didInitializeContextGraphMutex) {
>   AutoLocker lock(this);
>   visitor->trace(m_referencedNodes);
> } else {
>   visitor->trace(m_referencedNodes);
> }
> 
> ?

m_referencedNode is always empty if m_didInitializeContextGraphMutex is false.
But tracing it is safer.  Will do.

[haraken, 2014-12-04 06:03:42]

LGTM

[tkent, 2014-12-04 06:38:12]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-12-04 06:38:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/776203002/20001

[commit-bot: I haz the power, 2014-12-04 07:14:06]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186482