Moving member never_save_password of ManagePasswordsBubbleView to ManagePasswordsBubbleModel

Moving member never_save_password of ManagePasswordsBubbleView to ManagePasswordsBubbleModel

ManagePasswordsBubbleView::never_save_password_ belong to ManagePasswordsBubbleModel

R=mkwst@chromium.org
BUG=438841
Committed: https://crrev.com/f5575c64436449f2371118df6ed2f5b0640c69db
Cr-Commit-Position: refs/heads/master@{#307015}

[melandory, 2014-12-03 23:48:53]

Patchset #1 (id:1) has been deleted

[melandory, 2014-12-03 23:52:16]

Patchset #1 (id:20001) has been deleted

[melandory, 2014-12-03 23:54:42]

Patchset #1 (id:40001) has been deleted

[Mike West, 2014-12-04 00:11:48]

This makes sense to me, thanks! A few comments inline.

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/manage_passwords_bubble_model.cc (right):

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:48: if
(!never_save_passwords)
Negations are confusing. :)

How about something more like:

    return l10n_util::GetStringUTF16(never_save_passwords ? IDS_MANAGE... :
IDS_SAVE_...);

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:75: title_ =
PendingStateTitleBasedOnSafePasswordPref(never_save_passwords_);
Nit: s/Safe/Save/?

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:162:
PendingStateTitleBasedOnSafePasswordPref(never_save_passwords_);
You're not doing anything with the result of this call. Is that intentional?

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:167:
PendingStateTitleBasedOnSafePasswordPref(never_save_passwords_);
Ditto.

[melandory, 2014-12-04 09:41:30]

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/manage_passwords_bubble_model.cc (right):

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:48: if
(!never_save_passwords)
On 2014/12/04 00:11:48, Mike West (OOO) wrote:
> Negations are confusing. :)
> 
> How about something more like:
> 
>     return l10n_util::GetStringUTF16(never_save_passwords ? IDS_MANAGE... :
> IDS_SAVE_...);

Done.

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:75: title_ =
PendingStateTitleBasedOnSafePasswordPref(never_save_passwords_);
On 2014/12/04 00:11:48, Mike West (OOO) wrote:
> Nit: s/Safe/Save/?

Done.

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:162:
PendingStateTitleBasedOnSafePasswordPref(never_save_passwords_);
On 2014/12/04 00:11:48, Mike West (OOO) wrote:
> You're not doing anything with the result of this call. Is that intentional?

Nope. It's bug, thanks for catching.

https://codereview.chromium.org/775843005/diff/50001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:167:
PendingStateTitleBasedOnSafePasswordPref(never_save_passwords_);
On 2014/12/04 00:11:48, Mike West (OOO) wrote:
> Ditto.

Done.

[Mike West, 2014-12-04 13:35:58]

LGTM. Thanks!

[melandory, 2014-12-05 12:29:31]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2014-12-05 12:29:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/775843005/60001

[commit-bot: I haz the power, 2014-12-05 13:13:14]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2014-12-05 13:14:08]

Patchset 2 (id:??) landed as
https://crrev.com/f5575c64436449f2371118df6ed2f5b0640c69db
Cr-Commit-Position: refs/heads/master@{#307015}