Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 775843005: Moving member never_save_password of ManagePasswordsBubbleView to ManagePasswordsBubbleModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index d572f6e3cc078e4ebffe186b539f8d326e7d59ee..c82651b8481e8bcccb6169d12de3cc9e81946628 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -43,13 +43,20 @@ void RecordExperimentStatistics(content::WebContents* web_contents,
password_bubble_experiment::RecordBubbleClosed(profile->GetPrefs(), reason);
}
+base::string16 PendingStateTitleBasedOnSavePasswordPref(
+ bool never_save_passwords) {
+ return l10n_util::GetStringUTF16(
+ never_save_passwords ? IDS_MANAGE_PASSWORDS_BLACKLIST_CONFIRMATION_TITLE
+ : IDS_SAVE_PASSWORD);
+}
+
} // namespace
ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
content::WebContents* web_contents)
: content::WebContentsObserver(web_contents),
- display_disposition_(
- metrics_util::AUTOMATIC_WITH_PASSWORD_PENDING),
+ never_save_passwords_(false),
+ display_disposition_(metrics_util::AUTOMATIC_WITH_PASSWORD_PENDING),
dismissal_reason_(metrics_util::NOT_DISPLAYED) {
ManagePasswordsUIController* controller =
ManagePasswordsUIController::FromWebContents(web_contents);
@@ -63,7 +70,7 @@ ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
best_matches_ = controller->best_matches();
if (password_manager::ui::IsPendingState(state_)) {
- title_ = l10n_util::GetStringUTF16(IDS_SAVE_PASSWORD);
+ title_ = PendingStateTitleBasedOnSavePasswordPref(never_save_passwords_);
} else if (state_ == password_manager::ui::BLACKLIST_STATE) {
title_ = l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_BLACKLISTED_TITLE);
} else if (state_ == password_manager::ui::CONFIRMATION_STATE) {
@@ -148,6 +155,16 @@ void ManagePasswordsBubbleModel::OnNopeClicked() {
state_ = password_manager::ui::PENDING_PASSWORD_STATE;
}
+void ManagePasswordsBubbleModel::OnConfirmationForNeverForThisSite() {
+ never_save_passwords_ = true;
+ title_ = PendingStateTitleBasedOnSavePasswordPref(never_save_passwords_);
+}
+
+void ManagePasswordsBubbleModel::OnUndoNeverForThisSite() {
+ never_save_passwords_ = false;
+ title_ = PendingStateTitleBasedOnSavePasswordPref(never_save_passwords_);
+}
+
void ManagePasswordsBubbleModel::OnNeverForThisSiteClicked() {
dismissal_reason_ = metrics_util::CLICKED_NEVER;
RecordExperimentStatistics(web_contents(), dismissal_reason_);

Powered by Google App Engine
This is Rietveld 408576698