Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 775693003: Move more don't-crankshaft computation to numbering pass (Closed)

Created:
6 years ago by wingo
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Move more don't-crankshaft computation to numbering pass The "do I inline?" decision needs many of the same inputs as the "should I even try to crankshaft?" decision. This change consolidates these checks in the numbering pass. It also removes the is_generator() check, as that's already handled when visiting the initial Yield expression. R=svenpanne@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -39 lines) Patch
M src/ast-numbering.cc View 4 chunks +23 lines, -11 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wingo
6 years ago (2014-12-02 17:13:20 UTC) #1
wingo
FWIW I am not trying to revive crankshaft; rather this is a followup to https://codereview.chromium.org/755333003.
6 years ago (2014-12-02 17:22:52 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-03 14:24:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775693003/1
6 years ago (2014-12-03 14:27:12 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-03 14:52:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698