Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 755333003: Do not try to inline if the function has an illegal redeclaration. (Closed)

Created:
6 years ago by Jarin
Modified:
6 years ago
Reviewers:
wingo, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Do not try to inline if the function has an illegal redeclaration. R=mvstanton@chromium.org BUG=chromium:436896 LOG=n

Patch Set 1 #

Patch Set 2 : Fix the exception expectation #

Patch Set 3 : Fix license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M src/hydrogen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-436896.js View 1 2 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
Could you take a look, please? It probably solve some of the other problems with ...
6 years ago (2014-11-26 15:43:17 UTC) #2
mvstanton
lgtm
6 years ago (2014-11-26 15:48:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755333003/40001
6 years ago (2014-11-26 15:49:42 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-26 16:32:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698