Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3385)

Unified Diff: cc/debug/rasterize_and_record_benchmark_impl.cc

Issue 775483002: cc: Remove max tiles and skewport constants from tiling client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl.h » ('j') | cc/layers/picture_layer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/debug/rasterize_and_record_benchmark_impl.cc
diff --git a/cc/debug/rasterize_and_record_benchmark_impl.cc b/cc/debug/rasterize_and_record_benchmark_impl.cc
index e276a41c17854347638006c67e027b094571fb04..97c960232778a091b0ccb80986c0d60a88bffdf4 100644
--- a/cc/debug/rasterize_and_record_benchmark_impl.cc
+++ b/cc/debug/rasterize_and_record_benchmark_impl.cc
@@ -121,18 +121,6 @@ class FixedInvalidationPictureLayerTilingClient
return base_client_->GetMaxTilePriorityBin();
}
- size_t GetMaxTilesForInterestArea() const override {
- return base_client_->GetMaxTilesForInterestArea();
- }
-
- float GetSkewportTargetTimeInSeconds() const override {
- return base_client_->GetSkewportTargetTimeInSeconds();
- }
-
- int GetSkewportExtrapolationLimitInContentPixels() const override {
- return base_client_->GetSkewportExtrapolationLimitInContentPixels();
- }
-
WhichTree GetTree() const override { return base_client_->GetTree(); }
bool RequiresHighResToDraw() const override {
@@ -213,7 +201,16 @@ void RasterizeAndRecordBenchmarkImpl::RunOnLayer(PictureLayerImpl* layer) {
FixedInvalidationPictureLayerTilingClient client(
layer, gfx::Rect(layer->content_bounds()));
- auto tiling_set = PictureLayerTilingSet::Create(&client);
+
+ // These values reflect layer tree settings, but shouldn't affect this
+ // particular benchmark.
+ const size_t kMaxTilesForInterestArea = 128;
+ const float kSkewportTargetTimeInSeconds = 1.0f;
+ const int kSkewportExtrapolationLimitInContentPixels = 2000;
+
+ auto tiling_set = PictureLayerTilingSet::Create(
+ &client, kMaxTilesForInterestArea, kSkewportTargetTimeInSeconds,
+ kSkewportExtrapolationLimitInContentPixels);
PictureLayerTiling* tiling =
tiling_set->AddTiling(layer->contents_scale_x(), layer->bounds());
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl.h » ('j') | cc/layers/picture_layer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698