Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: cc/debug/rasterize_and_record_benchmark_impl.cc

Issue 775483002: cc: Remove max tiles and skewport constants from tiling client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl.h » ('j') | cc/layers/picture_layer_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/debug/rasterize_and_record_benchmark_impl.h" 5 #include "cc/debug/rasterize_and_record_benchmark_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 PictureLayerTiling* GetRecycledTwinTiling( 115 PictureLayerTiling* GetRecycledTwinTiling(
116 const PictureLayerTiling* tiling) override { 116 const PictureLayerTiling* tiling) override {
117 return base_client_->GetRecycledTwinTiling(tiling); 117 return base_client_->GetRecycledTwinTiling(tiling);
118 } 118 }
119 119
120 TilePriority::PriorityBin GetMaxTilePriorityBin() const override { 120 TilePriority::PriorityBin GetMaxTilePriorityBin() const override {
121 return base_client_->GetMaxTilePriorityBin(); 121 return base_client_->GetMaxTilePriorityBin();
122 } 122 }
123 123
124 size_t GetMaxTilesForInterestArea() const override {
125 return base_client_->GetMaxTilesForInterestArea();
126 }
127
128 float GetSkewportTargetTimeInSeconds() const override {
129 return base_client_->GetSkewportTargetTimeInSeconds();
130 }
131
132 int GetSkewportExtrapolationLimitInContentPixels() const override {
133 return base_client_->GetSkewportExtrapolationLimitInContentPixels();
134 }
135
136 WhichTree GetTree() const override { return base_client_->GetTree(); } 124 WhichTree GetTree() const override { return base_client_->GetTree(); }
137 125
138 bool RequiresHighResToDraw() const override { 126 bool RequiresHighResToDraw() const override {
139 return base_client_->RequiresHighResToDraw(); 127 return base_client_->RequiresHighResToDraw();
140 } 128 }
141 129
142 private: 130 private:
143 PictureLayerTilingClient* base_client_; 131 PictureLayerTilingClient* base_client_;
144 Region invalidation_; 132 Region invalidation_;
145 }; 133 };
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 } 194 }
207 195
208 TaskGraphRunner* task_graph_runner = RasterWorkerPool::GetTaskGraphRunner(); 196 TaskGraphRunner* task_graph_runner = RasterWorkerPool::GetTaskGraphRunner();
209 DCHECK(task_graph_runner); 197 DCHECK(task_graph_runner);
210 198
211 if (!task_namespace_.IsValid()) 199 if (!task_namespace_.IsValid())
212 task_namespace_ = task_graph_runner->GetNamespaceToken(); 200 task_namespace_ = task_graph_runner->GetNamespaceToken();
213 201
214 FixedInvalidationPictureLayerTilingClient client( 202 FixedInvalidationPictureLayerTilingClient client(
215 layer, gfx::Rect(layer->content_bounds())); 203 layer, gfx::Rect(layer->content_bounds()));
216 auto tiling_set = PictureLayerTilingSet::Create(&client); 204
205 // These values reflect layer tree settings, but shouldn't affect this
206 // particular benchmark.
207 const size_t kMaxTilesForInterestArea = 128;
208 const float kSkewportTargetTimeInSeconds = 1.0f;
209 const int kSkewportExtrapolationLimitInContentPixels = 2000;
210
211 auto tiling_set = PictureLayerTilingSet::Create(
212 &client, kMaxTilesForInterestArea, kSkewportTargetTimeInSeconds,
213 kSkewportExtrapolationLimitInContentPixels);
217 214
218 PictureLayerTiling* tiling = 215 PictureLayerTiling* tiling =
219 tiling_set->AddTiling(layer->contents_scale_x(), layer->bounds()); 216 tiling_set->AddTiling(layer->contents_scale_x(), layer->bounds());
220 tiling->CreateAllTilesForTesting(); 217 tiling->CreateAllTilesForTesting();
221 for (PictureLayerTiling::CoverageIterator it( 218 for (PictureLayerTiling::CoverageIterator it(
222 tiling, layer->contents_scale_x(), layer->visible_content_rect()); 219 tiling, layer->contents_scale_x(), layer->visible_content_rect());
223 it; 220 it;
224 ++it) { 221 ++it) {
225 DCHECK(*it); 222 DCHECK(*it);
226 223
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 pixels_rasterized_with_non_solid_color(0), 267 pixels_rasterized_with_non_solid_color(0),
271 pixels_rasterized_as_opaque(0), 268 pixels_rasterized_as_opaque(0),
272 total_layers(0), 269 total_layers(0),
273 total_picture_layers(0), 270 total_picture_layers(0),
274 total_picture_layers_with_no_content(0), 271 total_picture_layers_with_no_content(0),
275 total_picture_layers_off_screen(0) {} 272 total_picture_layers_off_screen(0) {}
276 273
277 RasterizeAndRecordBenchmarkImpl::RasterizeResults::~RasterizeResults() {} 274 RasterizeAndRecordBenchmarkImpl::RasterizeResults::~RasterizeResults() {}
278 275
279 } // namespace cc 276 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl.h » ('j') | cc/layers/picture_layer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698