Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: mojo/tools/mojob.py

Issue 775343003: Makes mojob create a different directory when --asan is specified (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: parent_parent Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/tools/get_test_list.py ('k') | mojo/tools/mopy/paths.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mojob.py
diff --git a/mojo/tools/mojob.py b/mojo/tools/mojob.py
index 7225288ea5b2a34fbbe45ab57bbbede8880a3971..af007b55c4cfd3316bf2a88742776e295b9fa21e 100755
--- a/mojo/tools/mojob.py
+++ b/mojo/tools/mojob.py
@@ -153,9 +153,6 @@ def _run_tests(config, test_types):
config = deepcopy(config)
config.values['test_types'] = test_types
- if _get_gn_arg_value(_get_out_dir(config), 'is_asan') == 'true':
- config.values["sanitizer"] = Config.SANITIZER_ASAN
-
test_list = GetTestList(config)
dry_run = config.values.get('dry_run')
final_exit_code = 0
@@ -194,6 +191,9 @@ def main():
'/testing Mojo components easier.')
parent_parser = argparse.ArgumentParser(add_help=False)
+ parent_parser.add_argument('--asan', help='Uses Address Sanitizer',
viettrungluu 2014/12/05 01:35:05 Could you, as a drive-by, update "uses" to "Use"?
sky 2014/12/05 16:50:24 Done.
+ action='store_true')
+
debug_group = parent_parser.add_mutually_exclusive_group()
debug_group.add_argument('--debug', help='Debug build (default)',
default=True, action='store_true')
@@ -215,8 +215,6 @@ def main():
gn_parser = subparsers.add_parser('gn', parents=[parent_parser],
help='Run gn for mojo (does not sync).')
gn_parser.set_defaults(func=gn)
- gn_parser.add_argument('--asan', help='Uses Address Sanitizer',
- action='store_true')
gn_parser.add_argument('--with-dart', help='Configure the Dart bindings',
action='store_true')
clang_group = gn_parser.add_mutually_exclusive_group()
« no previous file with comments | « mojo/tools/get_test_list.py ('k') | mojo/tools/mopy/paths.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698