Makes mojob create a different directory when --asan is specified

mojo/tools/mojob.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This a simple script to make building/testing Mojo components easier.
 
 import argparse
 from copy import deepcopy
 import os
@@ skipping 135 matching lines @@
     return subprocess.call(['ninja', '-C', out_dir, 'root'])
 
 
 def _run_tests(config, test_types):
   """Runs the tests of the given type(s) for the given config."""
 
   assert isinstance(test_types, list)
   config = deepcopy(config)
   config.values['test_types'] = test_types
 
-  if _get_gn_arg_value(_get_out_dir(config), 'is_asan') == 'true':
-    config.values["sanitizer"] = Config.SANITIZER_ASAN
-
   test_list = GetTestList(config)
   dry_run = config.values.get('dry_run')
   final_exit_code = 0
   for entry in test_list:
     print 'Running: %s' % entry['name']
     print 'Command: %s' % entry['command']
     if dry_run:
       continue
 
     exit_code = subprocess.call(entry['command'])
@@ skipping 18 matching lines @@
   return _run_tests(config, ['dart'])
 
 
 def main():
   os.chdir(Paths().src_root)
 
   parser = argparse.ArgumentParser(description='A script to make building'
       '/testing Mojo components easier.')
 
   parent_parser = argparse.ArgumentParser(add_help=False)
+  parent_parser.add_argument('--asan', help='Uses Address Sanitizer',

[viettrungluu, 2014/12/05 01:35:05]

Could you, as a drive-by, update "uses" to "Use"? (I can't unsee this.)

[sky, 2014/12/05 16:50:24]

Done.

+                             action='store_true')
+
   debug_group = parent_parser.add_mutually_exclusive_group()
   debug_group.add_argument('--debug', help='Debug build (default)',
                            default=True, action='store_true')
   debug_group.add_argument('--release', help='Release build', default=False,
                            dest='debug', action='store_false')
 
   os_group = parent_parser.add_mutually_exclusive_group()
   os_group.add_argument('--android', help='Build for Android',
                         action='store_true')
   os_group.add_argument('--chromeos', help='Build for ChromeOS',
                         action='store_true')
 
   subparsers = parser.add_subparsers()
 
   sync_parser = subparsers.add_parser('sync', parents=[parent_parser],
       help='Sync using gclient (does not run gn).')
   sync_parser.set_defaults(func=sync)
 
   gn_parser = subparsers.add_parser('gn', parents=[parent_parser],
                                     help='Run gn for mojo (does not sync).')
   gn_parser.set_defaults(func=gn)
-  gn_parser.add_argument('--asan', help='Uses Address Sanitizer',
-                         action='store_true')
   gn_parser.add_argument('--with-dart', help='Configure the Dart bindings',
                          action='store_true')
   clang_group = gn_parser.add_mutually_exclusive_group()
   clang_group.add_argument('--clang', help='Use Clang (default)', default=None,
                            action='store_true')
   clang_group.add_argument('--gcc', help='Use GCC',
                            dest='clang', action='store_false')
   goma_group = gn_parser.add_mutually_exclusive_group()
   goma_group.add_argument('--goma',
                           help='Use Goma (if $GOMA_DIR is set or $HOME/goma '
@@ skipping 37 matching lines @@
       help='Run Dart unit tests (does not build).')
   darttest_parser.set_defaults(func=darttest)
 
   args = parser.parse_args()
   config = _args_to_config(args)
   return args.func(config)
 
 
 if __name__ == '__main__':
   sys.exit(main())