Fix Apple Color Emoji support for OS X 10.7+

Fix Apple Color Emoji support for OS X 10.7+

BUG=chromium:62435

[Jiang Jiang, 2014-12-04 13:59:23]

jiangj@opera.com changed reviewers:
+ bungeman@chromium.org

[Jiang Jiang, 2014-12-04 13:59:23]

Ben, this is more like a proof of concept patch, feel free to point out problems
and let me know how to update tests for this (if there is any).

[bungeman-skia, 2014-12-04 14:47:13]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2014-12-04 14:47:14]

If it were that easy, we would have done it already :-) Please see
https://codereview.chromium.org/770383002/ and a possible pre-requisite
https://codereview.chromium.org/748883005/ .

https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:120: return CFStringCompare(name.get(),
CFSTR("Apple Color Emoji"), 0) == kCFCompareEqualTo;
No way we're doing this (testing by name).

https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:834: sk_memset_rect32(image, context.fIsColorEmoji
? 0xFFFFFFFF : 0, glyph.fWidth, glyph.fHeight, rowBytes);
We cannot make the background opaque.

https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:854: // CGContextSetTextMatrix does not work with
color glyphs, so we use the
This isn't quite true, what happens is CoreText won't scale the bitmap up.
That's a whole 'nother issue.

https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:1166: return SkPreMultiplyARGB(0xFF, r, g, b);   
// red
We cannot make these opaque, transparency must be maintained.

[Jiang Jiang, 2014-12-04 16:09:03]

On 2014/12/04 14:47:14, bungeman1 wrote:
> If it were that easy, we would have done it already :-) Please see
> https://codereview.chromium.org/770383002/ and a possible pre-requisite
> https://codereview.chromium.org/748883005/ .
> 
> https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp
> File src/ports/SkFontHost_mac.cpp (right):
> 
>
https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
> src/ports/SkFontHost_mac.cpp:120: return CFStringCompare(name.get(),
> CFSTR("Apple Color Emoji"), 0) == kCFCompareEqualTo;
> No way we're doing this (testing by name).
> 
>
https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
> src/ports/SkFontHost_mac.cpp:834: sk_memset_rect32(image,
context.fIsColorEmoji
> ? 0xFFFFFFFF : 0, glyph.fWidth, glyph.fHeight, rowBytes);
> We cannot make the background opaque.
> 
>
https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
> src/ports/SkFontHost_mac.cpp:854: // CGContextSetTextMatrix does not work with
> color glyphs, so we use the
> This isn't quite true, what happens is CoreText won't scale the bitmap up.
> That's a whole 'nother issue.
> 
>
https://codereview.chromium.org/775323002/diff/1/src/ports/SkFontHost_mac.cpp...
> src/ports/SkFontHost_mac.cpp:1166: return SkPreMultiplyARGB(0xFF, r, g, b);   
> // red
> We cannot make these opaque, transparency must be maintained.

Thanks for the comments! I guess I will put this on hold for now then.

[bungeman-skia, 2014-12-12 20:34:36]

Closing in favor of https://codereview.chromium.org/770383002/ .