Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 775153002: Implement unset value handling (Closed)

Created:
6 years ago by rwlbuis
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement unset value handling This patch accepts unset as a valid CSS value and creates a CSSUnsetValue object for it. Then when resolving it the rules stated in below link are implemented: http://dev.w3.org/csswg/css-cascade/#valuedef-unset Add a test for the new behavior. BUG=431689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186604

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : Fix failing test + copyrights #

Patch Set 4 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -4 lines) Patch
A LayoutTests/fast/css/unset-keyword.html View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/unset-keyword-expected.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/css/CSSUnsetValue.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A + Source/core/css/CSSUnsetValue.cpp View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 1 6 chunks +14 lines, -0 lines 0 comments Download
M Source/core/css/CSSValuePool.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rwlbuis
PTAL. I had a hard time coming up with a generalized test for unset so ...
6 years ago (2014-12-04 20:44:17 UTC) #3
Timothy Loh
On 2014/12/04 20:44:17, rwlbuis wrote: > PTAL. I had a hard time coming up with ...
6 years ago (2014-12-05 00:08:21 UTC) #4
Timothy Loh
On 2014/12/05 00:08:21, Timothy Loh wrote: > On 2014/12/04 20:44:17, rwlbuis wrote: > > PTAL. ...
6 years ago (2014-12-05 00:11:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/775153002/80001
6 years ago (2014-12-05 15:26:43 UTC) #7
rwlbuis
On 2014/12/05 00:11:46, Timothy Loh wrote: > On 2014/12/05 00:08:21, Timothy Loh wrote: > > ...
6 years ago (2014-12-05 16:27:36 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=186604
6 years ago (2014-12-05 16:46:51 UTC) #9
Ilya Sherman
6 years ago (2014-12-05 22:33:53 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/782853002/ by isherman@chromium.org.

The reason for reverting is: This broke the Linux Oilpan Builder.

Logs:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/b...

BUG=439604.

Powered by Google App Engine
This is Rietveld 408576698