cc: Implement unified BeginFrame on aura

content/browser/renderer_host/render_widget_host_view_mac.mm

Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 78594232ff08a409cd787df036f8031d9e350ed6..1dde02781d267dee5158af27f339d1dea7da15f2 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -440,12 +440,6 @@ void RenderWidgetHostViewMac::DelegatedFrameHostOnLostCompositorResources() {
   render_widget_host_->ScheduleComposite();
 }
 
-void RenderWidgetHostViewMac::DelegatedFrameHostUpdateVSyncParameters(

[brianderson, 2015/03/02 22:38:16]

Can you have the SendBeginFrame forward the timebase and interval to
render_widget_host_->UpdateVSyncParameters here?

You have a separate patch that will get the VSync callback directly for MacOS,
but until then, we'll need to make sure to call UpdateVSyncParameters. Otherwise
the Renderer will never get the real vsync info.

[simonhong, 2015/03/02 22:52:21]

I removed this method because MacOSX didn't receive vsync infos from
CompositorVSyncManager.
IIUC, Mac only relys on vsync info from DisplayLinkMac.

[brianderson, 2015/03/04 02:16:18]

Thanks for pointing that out. You can ignore my comment then =)

-    const base::TimeTicks& timebase,
-    const base::TimeDelta& interval) {
-  render_widget_host_->UpdateVSyncParameters(timebase, interval);
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 // AcceleratedWidgetMacNSView, public:
 
@@ -552,7 +546,7 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget,
 
   if (IsDelegatedRendererEnabled()) {
     root_layer_.reset(new ui::Layer(ui::LAYER_SOLID_COLOR));
-    delegated_frame_host_.reset(new DelegatedFrameHost(this));
+    delegated_frame_host_.reset(new DelegatedFrameHost(this, false));

[brianderson, 2015/03/02 22:38:16]

To forward SendBeginFrame to UpdateVSyncParameters, this will have to be "true"
after which you can just get rid of this flag since no instance will be "false".

[simonhong, 2015/03/03 22:54:12]

This flag will be removed when unified BeginFrame is enabled on Mac.
Until unified BeginFrame is enabled on Mac, this flag should be set to false
because vsync info is delivered from DisplayLinkMac to RenderWidgetHost via
RWHVMac.

   }
 
   gfx::Screen::GetScreenFor(cocoa_view_)->AddObserver(this);