cc: Implement unified BeginFrame on aura

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import <objc/runtime.h>
 #include <OpenGL/gl.h>
 #include <QuartzCore/QuartzCore.h>
 
@@ skipping 422 matching lines @@
     int output_surface_id,
     const cc::CompositorFrameAck& ack) {
   render_widget_host_->Send(new ViewMsg_ReclaimCompositorResources(
       render_widget_host_->GetRoutingID(), output_surface_id, ack));
 }
 
 void RenderWidgetHostViewMac::DelegatedFrameHostOnLostCompositorResources() {
   render_widget_host_->ScheduleComposite();
 }
 
-void RenderWidgetHostViewMac::DelegatedFrameHostUpdateVSyncParameters(

[brianderson, 2015/03/02 22:38:16]

Can you have the SendBeginFrame forward the timebase and interval to
render_widget_host_->UpdateVSyncParameters here?

You have a separate patch that will get the VSync callback directly for MacOS,
but until then, we'll need to make sure to call UpdateVSyncParameters. Otherwise
the Renderer will never get the real vsync info.

[simonhong, 2015/03/02 22:52:21]

I removed this method because MacOSX didn't receive vsync infos from
CompositorVSyncManager.
IIUC, Mac only relys on vsync info from DisplayLinkMac.

[brianderson, 2015/03/04 02:16:18]

Thanks for pointing that out. You can ignore my comment then =)

-    const base::TimeTicks& timebase,
-    const base::TimeDelta& interval) {
-  render_widget_host_->UpdateVSyncParameters(timebase, interval);
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 // AcceleratedWidgetMacNSView, public:
 
 NSView* RenderWidgetHostViewMac::AcceleratedWidgetGetNSView() const {
   return cocoa_view_;
 }
 
 bool RenderWidgetHostViewMac::AcceleratedWidgetShouldIgnoreBackpressure()
     const {
   // If vsync is disabled, then always draw and ack frames immediately.
@@ skipping 86 matching lines @@
   // ready to draw.
   background_layer_.reset([[CALayer alloc] init]);
   base::ScopedCFTypeRef<CGColorRef> background(
       gfx::CGColorCreateFromSkColor(background_color_));
   [background_layer_ setBackgroundColor:background];
   [cocoa_view_ setLayer:background_layer_];
   [cocoa_view_ setWantsLayer:YES];
 
   if (IsDelegatedRendererEnabled()) {
     root_layer_.reset(new ui::Layer(ui::LAYER_SOLID_COLOR));
-    delegated_frame_host_.reset(new DelegatedFrameHost(this));
+    delegated_frame_host_.reset(new DelegatedFrameHost(this, false));

[brianderson, 2015/03/02 22:38:16]

To forward SendBeginFrame to UpdateVSyncParameters, this will have to be "true"
after which you can just get rid of this flag since no instance will be "false".

[simonhong, 2015/03/03 22:54:12]

This flag will be removed when unified BeginFrame is enabled on Mac.
Until unified BeginFrame is enabled on Mac, this flag should be set to false
because vsync info is delivered from DisplayLinkMac to RenderWidgetHost via
RWHVMac.

   }
 
   gfx::Screen::GetScreenFor(cocoa_view_)->AddObserver(this);
 
   if (!is_guest_view_hack_)
     render_widget_host_->SetView(this);
 }
 
 RenderWidgetHostViewMac::~RenderWidgetHostViewMac() {
   gfx::Screen::GetScreenFor(cocoa_view_)->RemoveObserver(this);
@@ skipping 2865 matching lines @@
 
 // "-webkit-app-region: drag | no-drag" is implemented on Mac by excluding
 // regions that are not draggable. (See ControlRegionView in
 // native_app_window_cocoa.mm). This requires the render host view to be
 // draggable by default.
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
 
 @end