CustomScrollbar Style not updated for IFrame.

CustomScrollbar of IFrame elements style needs to be updated.

CustomScrollbar of IFrame elements style needs to be updated. IFrame 
element is added as widget for frameview. If CustomScrollbar is 
defined in the page, then the CustomScrollbar of IFrame style needs
to be recalculated. This patch calls RenderPart scrollbars styleChanged.

BUG=438596
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186760

[MuVen, 2014-12-04 14:27:04]

sataya.m@samsung.com changed reviewers:
+ skobes@chromium.org

[MuVen, 2014-12-04 14:27:04]

Hi Skobes,

I have implemented the API to call CS styleDidChange for IFrame Custom
Scrollbars.PTAL.

Thanks,
~MuVen.

[MuVen, 2014-12-04 15:41:38]

sataya.m@samsung.com changed reviewers:
+ pdr@chromium.org

[MuVen, 2014-12-04 15:47:10]

https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:346: void
FrameView::recalculateWidgetCustomScrollbarStyle()
with this changes any scrollbar pertaining to frameView shall be invalidated.
may be using ChildrenWidgetSet m_children is better than using RenderPart
?(share your view).

The problem is with RLSA custom-scrollbar. in RLSA setHasVerticalScrollbar is
triggered on scrollbar creation and the scrollbars are not preserved, just like
in FrameView::addWidget(). May if we can store those scrollbar and call
styleChanged ? rather than entire page invalidation call ?

[MuVen, 2014-12-04 15:51:32]

im sorry i miss read the code. kindly ignore the second comment.

[skobes, 2014-12-04 17:18:39]

https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:351: for (size_t i = 0; i < parts.size() &&
renderView(); ++i) {
This looks like it does the equivalent of
FrameView::recalculateCustomScrollbarStyle on each iframe.  But
recalculateCustomScrollbarStyle is called by RenderBox::styleDidChange. 
Shouldn't this happen automatically through the style invalidation of the
iframe's document element?

[MuVen, 2014-12-04 17:50:28]

PTAL.

https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:351: for (size_t i = 0; i < parts.size() &&
renderView(); ++i) {
True. Instead of writing one more api i have reused
recalculateCustomScrollbarStyl from RenderPart itself. But for ::inactive we
have to write this API so that it shall invalidate on focusActive Changed.

[MuVen, 2014-12-04 17:58:57]

On 2014/12/04 17:50:28, muven wrote:
> PTAL.
> 
>
https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView.cpp
> File Source/core/frame/FrameView.cpp (right):
> 
>
https://codereview.chromium.org/774953003/diff/1/Source/core/frame/FrameView....
> Source/core/frame/FrameView.cpp:351: for (size_t i = 0; i < parts.size() &&
> renderView(); ++i) {
> True. Instead of writing one more api i have reused
> recalculateCustomScrollbarStyl from RenderPart itself. But for ::inactive we
> have to write this API so that it shall invalidate on focusActive Changed.

Sry for spamming, may b for inactive i shall try rune approach tomo n  let u
know..
Speicific to this issue i see this is the perfect fix. Share u  r inputs on 
this.

[MuVen, 2014-12-08 16:39:02]

friendly ping !!!
pdr/skobes, PTAL.

[skobes, 2014-12-08 21:54:55]

lgtm with one nit

https://codereview.chromium.org/774953003/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderPart.cpp (right):

https://codereview.chromium.org/774953003/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderPart.cpp:212: // Recalculate CustomScrollbar Style
if IFrame Created with CustomScrollabrs.
Nit: typo, and unnecessary capitalization. Suggest:

// If the iframe has custom scrollbars, recalculate their style.

[MuVen, 2014-12-09 06:10:37]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2014-12-09 06:10:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/774953003/40001

[commit-bot: I haz the power, 2014-12-09 07:17:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186760