Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: Source/core/rendering/RenderPart.cpp

Issue 774953003: CustomScrollbar Style not updated for IFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressed review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/scrollbars/custom-scrollbar-for-iframe-changing-dynamically-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Simon Hausmann <hausmann@kde.org> 3 * (C) 2000 Simon Hausmann <hausmann@kde.org>
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 } 202 }
203 203
204 void RenderPart::styleDidChange(StyleDifference diff, const RenderStyle* oldStyl e) 204 void RenderPart::styleDidChange(StyleDifference diff, const RenderStyle* oldStyl e)
205 { 205 {
206 RenderReplaced::styleDidChange(diff, oldStyle); 206 RenderReplaced::styleDidChange(diff, oldStyle);
207 Widget* widget = this->widget(); 207 Widget* widget = this->widget();
208 208
209 if (!widget) 209 if (!widget)
210 return; 210 return;
211 211
212 // If the iframe has custom scrollbars, recalculate their style.
213 if (widget && widget->isFrameView())
214 toFrameView(widget)->recalculateCustomScrollbarStyle();
215
212 if (style()->visibility() != VISIBLE) { 216 if (style()->visibility() != VISIBLE) {
213 widget->hide(); 217 widget->hide();
214 } else { 218 } else {
215 widget->show(); 219 widget->show();
216 } 220 }
217 } 221 }
218 222
219 void RenderPart::layout() 223 void RenderPart::layout()
220 { 224 {
221 ASSERT(needsLayout()); 225 ASSERT(needsLayout());
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 if (widget->frameRect() == newFrame) 329 if (widget->frameRect() == newFrame)
326 return false; 330 return false;
327 331
328 RefPtrWillBeRawPtr<RenderPart> protector(this); 332 RefPtrWillBeRawPtr<RenderPart> protector(this);
329 RefPtrWillBeRawPtr<Node> protectedNode(node()); 333 RefPtrWillBeRawPtr<Node> protectedNode(node());
330 widget->setFrameRect(newFrame); 334 widget->setFrameRect(newFrame);
331 return widget->frameRect().size() != newFrame.size(); 335 return widget->frameRect().size() != newFrame.size();
332 } 336 }
333 337
334 } 338 }
OLDNEW
« no previous file with comments | « LayoutTests/scrollbars/custom-scrollbar-for-iframe-changing-dynamically-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698