Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 774953002: Always Reconstruct when stylesheets change. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Always Reconstruct when stylesheets change. In preparation of simplifying how we collect and process sheets now that we don't support descendant, sibling and tree boundary crossing rules we should switch to always going down the Reconstruct path. This might be somewhat slower to start, but because our rules are so much simpler we should be able to rebuild the StyleEngine to do something simpler and faster. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dfba5f05fcd597a9517de980c8fc4dae3a19620d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -436 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -4 lines 0 comments Download
D sky/engine/core/css/invalidation/StyleSheetInvalidationAnalysis.h View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 1 chunk +0 lines, -167 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +3 lines, -12 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 4 chunks +8 lines, -13 lines 0 comments Download
M sky/engine/core/dom/DocumentStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +8 lines, -21 lines 0 comments Download
M sky/engine/core/dom/ShadowTreeStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +8 lines, -15 lines 0 comments Download
M sky/engine/core/dom/StyleElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 5 chunks +18 lines, -31 lines 0 comments Download
M sky/engine/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +0 lines, -16 lines 0 comments Download
M sky/engine/core/dom/TreeScopeStyleSheetCollection.cpp View 2 chunks +0 lines, -87 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-03 04:07:10 UTC) #2
ojan
lgtm
6 years ago (2014-12-03 04:10:34 UTC) #3
esprehn
6 years ago (2014-12-03 04:34:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfba5f05fcd597a9517de980c8fc4dae3a19620d.

Powered by Google App Engine
This is Rietveld 408576698