Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: sky/engine/core/dom/Document.h

Issue 774953002: Always Reconstruct when stylesheets change. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/Document.h
diff --git a/sky/engine/core/dom/Document.h b/sky/engine/core/dom/Document.h
index 021f147b6049a63b1e11f6bc3022a5645d024d41..412da5d030a5e235ce29d14a8f1fd9f26f479849 100644
--- a/sky/engine/core/dom/Document.h
+++ b/sky/engine/core/dom/Document.h
@@ -129,13 +129,6 @@ struct AnnotatedRegionValue;
typedef EventWithHitTestResults<PlatformMouseEvent> MouseEventWithHitTestResults;
typedef int ExceptionCode;
-enum StyleResolverUpdateMode {
- // Discards the StyleResolver and rebuilds it.
- FullStyleUpdate,
- // Attempts to use StyleInvalidationAnalysis to avoid discarding the entire StyleResolver.
- AnalyzedStyleUpdate
-};
-
enum DocumentClass {
DefaultDocumentClass = 0,
HTMLDocumentClass = 1,
@@ -247,15 +240,13 @@ public:
StyleEngine* styleEngine() { return m_styleEngine.get(); }
// Called when one or more stylesheets in the document may have been added, removed, or changed.
- void styleResolverChanged(StyleResolverUpdateMode = FullStyleUpdate);
- void styleResolverMayHaveChanged();
+ void styleResolverChanged();
// FIXME: Switch all callers of styleResolverChanged to these or better ones and then make them
// do something smarter.
- void removedStyleSheet(StyleSheet*, StyleResolverUpdateMode = FullStyleUpdate);
+ void removedStyleSheet(StyleSheet*);
void addedStyleSheet(StyleSheet*) { styleResolverChanged(); }
- void modifiedStyleSheet(StyleSheet*, StyleResolverUpdateMode = FullStyleUpdate);
- void changedSelectorWatch() { styleResolverChanged(); }
+ void modifiedStyleSheet(StyleSheet*);
void evaluateMediaQueryList();
« no previous file with comments | « sky/engine/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698