Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 774783003: Remove redundant disable-impl-side-painting flag (Closed)

Created:
6 years ago by enne (OOO)
Modified:
5 years, 11 months ago
CC:
chrishtr, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant disable-impl-side-painting flag After https://codereview.chromium.org/818233003 lands, then all layout tests will explicitly either pass an enable or disable impl-side painting flag. This means that the content shell global disable flag can be removed. Once this has landed, then the whitelisted enable flags can also be cleaned up in Blink, and the flag removed entirely. BUG=381919 Committed: https://crrev.com/25e524f0c34abf359a51be3d63531d77e12b75ee Cr-Commit-Position: refs/heads/master@{#312582}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/app/shell_main_delegate.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
enne (OOO)
5 years, 11 months ago (2015-01-21 00:35:23 UTC) #2
chrishtr
lgtm
5 years, 11 months ago (2015-01-21 00:36:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774783003/100001
5 years, 11 months ago (2015-01-21 00:37:39 UTC) #6
enne (OOO)
+mkwst as alternate content/shell OWNER
5 years, 11 months ago (2015-01-22 00:42:01 UTC) #9
Mike West
LGTM.
5 years, 11 months ago (2015-01-22 06:57:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774783003/100001
5 years, 11 months ago (2015-01-22 06:58:57 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-22 07:45:37 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 07:46:54 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/25e524f0c34abf359a51be3d63531d77e12b75ee
Cr-Commit-Position: refs/heads/master@{#312582}

Powered by Google App Engine
This is Rietveld 408576698