Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 818233003: Add no-op disable-impl-side-painting flag to one suite (Closed)

Created:
5 years, 11 months ago by enne (OOO)
Modified:
5 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add no-op disable-impl-side-painting flag to one suite The virtual/deferred test suite needs to exist until impl-side painting is turned on everywhere. However, it would be nice to make all new directories have impl-side painting by default. Currently, the state is that: * Impl-side painting is enabled by default. * The enable flag overrides the disable flag. * Content shell passes the disable flag. * All test suites but deferred pass the enable flag. This patch adds a redundant disable flag to the deferred suite, which will allow the content shell flag to be removed and then the enable flag on all test suites to be removed afterwards. R=chrishtr@chromium.org BUG=381919 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M LayoutTests/VirtualTestSuites View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
enne (OOO)
5 years, 11 months ago (2015-01-21 00:27:51 UTC) #1
chrishtr
lgtm
5 years, 11 months ago (2015-01-21 00:32:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818233003/1
5 years, 11 months ago (2015-01-21 00:32:46 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 05:02:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188710

Powered by Google App Engine
This is Rietveld 408576698