Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 774763006: tools: Use hyphens instead of underscores for multi-word option names (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

tools: Use hyphens instead of underscores for multi-word option names. Option names like --mach-service are easier to type than --mach_service. Command-line tools don’t necessarily have the most ergonomic interfaces anyway, but this is an improvement. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/22b2f0cad7fb2ab0411cf1f5c15af07ab9bc3d22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M tools/catch_exception_tool.ad View 3 chunks +7 lines, -7 lines 0 comments Download
M tools/catch_exception_tool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/exception_port_tool.ad View 5 chunks +24 lines, -24 lines 0 comments Download
M tools/exception_port_tool.cc View 2 chunks +16 lines, -16 lines 0 comments Download
M tools/generate_dump.ad View 1 chunk +1 line, -1 line 0 comments Download
M tools/generate_dump.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/on_demand_service_tool.ad View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/on_demand_service_tool.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-12-04 21:25:28 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-04 21:41:38 UTC) #3
Mark Mentovai
6 years ago (2014-12-04 21:46:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22b2f0cad7fb2ab0411cf1f5c15af07ab9bc3d22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698