tools: Use hyphens instead of underscores for multi-word option names

tools/generate_dump.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 31 matching lines @@
   std::string dump_path;
   pid_t pid;
   bool suspend;
 };
 
 void Usage(const std::string& me) {
   fprintf(stderr,
 "Usage: %s [OPTION]... PID\n"
 "Generate a minidump file containing a snapshot of a running process.\n"
 "\n"
-"  -r, --no_suspend   don't suspend the target process during dump generation\n"
+"  -r, --no-suspend   don't suspend the target process during dump generation\n"
 "  -o, --output=FILE  write the minidump to FILE instead of minidump.PID\n"
 "      --help         display this help and exit\n"
 "      --version      output version information and exit\n",
           me.c_str());
   ToolSupport::UsageTail(me);
 }
 
 int GenerateDumpMain(int argc, char* argv[]) {
   const std::string me(basename(argv[0]));
 
   enum OptionFlags {
     // “Short” (single-character) options.
     kOptionOutput = 'o',
     kOptionNoSuspend = 'r',
 
     // Long options without short equivalents.
     kOptionLastChar = 255,
 
     // Standard options.
     kOptionHelp = -2,
     kOptionVersion = -3,
   };
 
   Options options = {};
   options.suspend = true;
 
   const struct option long_options[] = {
-      {"no_suspend", no_argument, nullptr, kOptionNoSuspend},
+      {"no-suspend", no_argument, nullptr, kOptionNoSuspend},
       {"output", required_argument, nullptr, kOptionOutput},
       {"help", no_argument, nullptr, kOptionHelp},
       {"version", no_argument, nullptr, kOptionVersion},
       {nullptr, 0, nullptr, 0},
   };
 
   int opt;
   while ((opt = getopt_long(argc, argv, "o:r", long_options, nullptr)) != -1) {
     switch (opt) {
       case kOptionOutput:
@@ skipping 78 matching lines @@
 
   return EXIT_SUCCESS;
 }
 
 }  // namespace
 }  // namespace crashpad
 
 int main(int argc, char* argv[]) {
   return crashpad::GenerateDumpMain(argc, argv);
 }