Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: cc/test/geometry_test_utils.h

Issue 774763004: Use EXPECT_EQ when possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/quads/render_pass_unittest.cc ('k') | cc/test/layer_tree_json_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/geometry_test_utils.h
diff --git a/cc/test/geometry_test_utils.h b/cc/test/geometry_test_utils.h
index b743f5879a99ac55e38acf20cfef4c8ec4213071..38112a889705c7479b2686903f736f1e9bc45cab 100644
--- a/cc/test/geometry_test_utils.h
+++ b/cc/test/geometry_test_utils.h
@@ -29,33 +29,6 @@ do { \
EXPECT_NEAR((expected).height(), (actual).height(), (abs_error)); \
} while (false)
-#define EXPECT_RECT_EQ(expected, actual) \
-do { \
- EXPECT_EQ((expected).x(), (actual).x()); \
- EXPECT_EQ((expected).y(), (actual).y()); \
- EXPECT_EQ((expected).width(), (actual).width()); \
- EXPECT_EQ((expected).height(), (actual).height()); \
-} while (false)
-
-#define EXPECT_SIZE_EQ(expected, actual) \
-do { \
- EXPECT_EQ((expected).width(), (actual).width()); \
- EXPECT_EQ((expected).height(), (actual).height()); \
-} while (false)
-
-#define EXPECT_POINT_EQ(expected, actual) \
-do { \
- EXPECT_EQ((expected).x(), (actual).x()); \
- EXPECT_EQ((expected).y(), (actual).y()); \
-} while (false)
-
-#define EXPECT_POINT3F_EQ(expected, actual) \
hush (inactive) 2014/12/04 20:10:18 On second thought, I need to keep EXPECT_POINT3F_E
danakj 2014/12/04 20:13:19 I think it's fine to use EXPECT_EQ, and if a test
-do { \
- EXPECT_FLOAT_EQ((expected).x(), (actual).x()); \
- EXPECT_FLOAT_EQ((expected).y(), (actual).y()); \
- EXPECT_FLOAT_EQ((expected).z(), (actual).z()); \
-} while (false)
-
#define EXPECT_VECTOR_EQ(expected, actual) \
danakj 2014/12/04 19:34:29 we could do these vector things too right?
hush (inactive) 2014/12/04 20:10:18 no... Right now EXPECT_VECTOR_EQ is treating |expe
danakj 2014/12/04 20:13:19 That sounds.. a bit weird. I'm guessing some place
do { \
EXPECT_EQ((expected).x(), (actual).x()); \
« no previous file with comments | « cc/quads/render_pass_unittest.cc ('k') | cc/test/layer_tree_json_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698