Issue 7747033: Merge 97702, 97820, 97976

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7747033: Merge 97702, 97820, 97976 (Closed)

Created:
9 years, 4 months ago by Lei Zhang

Modified:
9 years, 4 months ago

Reviewers:

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/branches/835/src/

Visibility:
Public.

Description

Merge 97702, 97820, 97976 Added a 'Reset' method in PrintMsg_Print_Params struct that is responsible for resetting the values of the member vars of the struct (used in place of calling memset(0) ) Review URL: http://codereview.chromium.org/7693017 Print Preview: Go from event driven print preview back to print preview with sync messages. The sync messages now go to the IO thread to avoid the potential deadlock on Windows. Review URL: http://codereview.chromium.org/7621087 Print Preview: Fix printing from print preview. Review URL: http://codereview.chromium.org/7720015 BUG=91057 , and probably a few more. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98332

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+452 lines, -285 lines)			Patch
M	chrome/browser/printing/print_preview_message_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View	5 chunks	+17 lines, -21 lines	0 comments	Download
M	chrome/browser/printing/printing_message_filter.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/printing/printing_message_filter.cc	View	6 chunks	+17 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui.h	View	4 chunks	+12 lines, -20 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui.cc	View	7 chunks	+79 lines, -32 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui_unittest.cc	View	2 chunks	+62 lines, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/print_messages.h	View	5 chunks	+78 lines, -31 lines	0 comments	Download
M	chrome/renderer/mock_printer.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.cc	View	5 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.h	View	6 chunks	+17 lines, -29 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	17 chunks	+77 lines, -114 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_browsertest.cc	View	5 chunks	+33 lines, -7 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_linux.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	printing/print_job_constants.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	printing/print_job_constants.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download