Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7693017: Removed use of memset with PrintMsg_Print_Params struct. (Closed)

Created:
9 years, 4 months ago by Aayush Kumar
Modified:
9 years, 4 months ago
Reviewers:
Lei Zhang, kmadhusu
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Added a 'Reset' method in PrintMsg_Print_Params struct that is responsible for resetting the values of the member vars of the struct (used in place of calling memset(0) ) BUG=93508 TEST= 1. open print preview 2. click advanced 3. cancel the native print dialog Ensure that browser doesn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97702

Patch Set 1 #

Patch Set 2 : New snapshot uploaded #

Total comments: 6

Patch Set 3 : Changes as per Kausalya's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -144 lines) Patch
M chrome/browser/printing/printing_message_filter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/print_messages.h View 1 2 2 chunks +67 lines, -23 lines 0 comments Download
A chrome/common/print_messages.cc View 1 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/renderer/mock_printer.h View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/renderer/mock_printer.cc View 4 chunks +3 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aayush Kumar
9 years, 4 months ago (2011-08-21 02:21:48 UTC) #1
kmadhusu
http://codereview.chromium.org/7693017/diff/4001/chrome/common/print_messages.h File chrome/common/print_messages.h (right): http://codereview.chromium.org/7693017/diff/4001/chrome/common/print_messages.h#newcode16 chrome/common/print_messages.h:16: #ifndef PRINTMSG_PARAMS_H_ PRINTMSG_PARAMS_H_ => CHROME_COMMON_PRINT_MESSAGES_H_ http://codereview.chromium.org/7693017/diff/4001/chrome/common/print_messages.h#newcode18 chrome/common/print_messages.h:18: struct PrintMsg_Print_Params ...
9 years, 4 months ago (2011-08-22 04:53:46 UTC) #2
Aayush Kumar
http://codereview.chromium.org/7693017/diff/4001/chrome/common/print_messages.h File chrome/common/print_messages.h (right): http://codereview.chromium.org/7693017/diff/4001/chrome/common/print_messages.h#newcode16 chrome/common/print_messages.h:16: #ifndef PRINTMSG_PARAMS_H_ On 2011/08/22 04:53:46, kmadhusu wrote: > PRINTMSG_PARAMS_H_ ...
9 years, 4 months ago (2011-08-22 17:17:44 UTC) #3
kmadhusu
LGTM
9 years, 4 months ago (2011-08-22 17:54:21 UTC) #4
Lei Zhang
9 years, 4 months ago (2011-08-22 18:54:29 UTC) #5 
LGTM++

Powered by Google App Engine
This is Rietveld 408576698