Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 774423002: Provides method for setting a BrowserCdmFactory for IPC-based CDM. (Closed)

Created:
6 years ago by gunsch
Modified:
6 years ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, lcwu1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Provides method for setting a BrowserCdmFactory for IPC-based CDM. R=xhwang@chromium.org BUG=435176 TEST=manually verified EME playback on ContentShell APK Committed: https://crrev.com/3334d1695296a5ef6d2a432119c5de44ca07ab15 Cr-Commit-Position: refs/heads/master@{#306964}

Patch Set 1 #

Patch Set 2 : upload missing files #

Total comments: 6

Patch Set 3 : address comments #

Patch Set 4 : update GN files #

Patch Set 5 : include base/logging.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -2 lines) Patch
M media/base/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A media/base/android/browser_cdm_factory_android.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M media/base/android/browser_cdm_factory_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/browser_cdm_factory.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A media/base/browser_cdm_factory.cc View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
gunsch
6 years ago (2014-12-04 01:53:39 UTC) #1
xhwang
lgtm with nits. https://codereview.chromium.org/774423002/diff/20001/media/base/android/browser_cdm_factory_android.h File media/base/android/browser_cdm_factory_android.h (right): https://codereview.chromium.org/774423002/diff/20001/media/base/android/browser_cdm_factory_android.h#newcode17 media/base/android/browser_cdm_factory_android.h:17: ~BrowserCdmFactoryAndroid() override {}; nit: here and ...
6 years ago (2014-12-04 21:28:19 UTC) #2
gunsch
https://codereview.chromium.org/774423002/diff/20001/media/base/android/browser_cdm_factory_android.h File media/base/android/browser_cdm_factory_android.h (right): https://codereview.chromium.org/774423002/diff/20001/media/base/android/browser_cdm_factory_android.h#newcode17 media/base/android/browser_cdm_factory_android.h:17: ~BrowserCdmFactoryAndroid() override {}; On 2014/12/04 21:28:19, xhwang wrote: > ...
6 years ago (2014-12-04 21:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774423002/40001
6 years ago (2014-12-04 21:54:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/39100)
6 years ago (2014-12-04 22:25:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774423002/60001
6 years ago (2014-12-05 01:06:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/39901)
6 years ago (2014-12-05 01:11:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774423002/80001
6 years ago (2014-12-05 01:20:18 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-05 03:15:24 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-05 03:17:04 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/3334d1695296a5ef6d2a432119c5de44ca07ab15
Cr-Commit-Position: refs/heads/master@{#306964}

Powered by Google App Engine
This is Rietveld 408576698