Issue 774243003: Make getComputedStyle's pseudoElt argument nullable again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 774243003: Make getComputedStyle's pseudoElt argument nullable again (Closed)

Created:
6 years ago by philipj_slow

Modified:
6 years ago

Reviewers:
arv (Not doing code reviews)

CC:
arv+blink, blink-reviews, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Make getComputedStyle's pseudoElt argument nullable again The getComputedStyle IDL was synced with the spec in r186258: https://codereview.chromium.org/765123002 This caused a performance regression in a Dromaeo test: http://dromaeo.com/?jslib-style-jquery The likely cause is that jQuery passes null for the pseudoElt argument: https://github.com/jquery/jquery/search?q=getComputedStyle With a non-nullable pseudoElt, null is converted to "null", which makes a measurable difference. Make it nullable again to avoid the problem. There's no observable difference, because only a pseudoElt beginning with a : actually does anything. BUG=438109 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186514

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/frame/DOMWindow.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/frame/Window.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

philipj_slow

PTAL. If this fixes the performance regression I'll suggest the same change in the spec.

6 years ago (2014-12-04 10:03:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774243003/1

6 years ago (2014-12-04 14:40:43 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-04 14:43:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186514