Sync the getComputedStyle() IDL with the spec

Sync the getComputedStyle() IDL with the spec

http://dev.w3.org/csswg/cssom/#extensions-to-the-window-interface

Firefox and IE already throw exceptions for getComputedStyle(),
getComputedStyle(null), getComputedStyle(undefined) and
getComputedStyle(document);

Previously, getComputedStyle() would fail the ASSERT(elt) in
LocalDOMWindow::getComputedStyle().

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186258

[philipj_slow, 2014-11-29 00:34:27]

philipj@opera.com changed reviewers:
+ arv@chromium.org

[philipj_slow, 2014-11-29 00:34:27]

Some idle cleanup, PTAL.

[arv (Not doing code reviews), 2014-12-01 14:20:09]

I'm actually worried that this will break content but lets try.

https://codereview.chromium.org/765123002/diff/1/LayoutTests/fast/css/getComp...
File LayoutTests/fast/css/getComputedStyle/getComputedStyle-exceptions.html
(right):

https://codereview.chromium.org/765123002/diff/1/LayoutTests/fast/css/getComp...
LayoutTests/fast/css/getComputedStyle/getComputedStyle-exceptions.html:13:
].forEach(function(expr)
I would skip the forEach here.

shouldThrow("getComputedStyle()");
shouldThrow("getComputedStyle(document)");
shouldThrow("getComputedStyle(null)");
shouldThrow("getComputedStyle(undefined)");

is just as readable.

https://codereview.chromium.org/765123002/diff/1/Source/core/frame/LocalDOMWi...
File Source/core/frame/LocalDOMWindow.h (right):

https://codereview.chromium.org/765123002/diff/1/Source/core/frame/LocalDOMWi...
Source/core/frame/LocalDOMWindow.h:136: void alert(const String& message)
override;
This looks unrelated

[philipj_slow, 2014-12-01 20:29:38]

simplify

[philipj_slow, 2014-12-01 20:48:54]

https://codereview.chromium.org/765123002/diff/1/LayoutTests/fast/css/getComp...
File LayoutTests/fast/css/getComputedStyle/getComputedStyle-exceptions.html
(right):

https://codereview.chromium.org/765123002/diff/1/LayoutTests/fast/css/getComp...
LayoutTests/fast/css/getComputedStyle/getComputedStyle-exceptions.html:13:
].forEach(function(expr)
On 2014/12/01 14:20:09, arv wrote:
> I would skip the forEach here.
> 
> shouldThrow("getComputedStyle()");
> shouldThrow("getComputedStyle(document)");
> shouldThrow("getComputedStyle(null)");
> shouldThrow("getComputedStyle(undefined)");
> 
> is just as readable.

Done.

https://codereview.chromium.org/765123002/diff/1/Source/core/frame/LocalDOMWi...
File Source/core/frame/LocalDOMWindow.h (right):

https://codereview.chromium.org/765123002/diff/1/Source/core/frame/LocalDOMWi...
Source/core/frame/LocalDOMWindow.h:136: void alert(const String& message)
override;
On 2014/12/01 14:20:09, arv wrote:
> This looks unrelated

Yeah, I forgot to say why in the description. The default argument String() for
alert() and getComputedStyle() aren't needed in the override because they aren't
omitted internally and also aren't part of the signature, so a different default
would still compile, I think. I've reverted the change and left alert() and
getComputedStyle() inconsistent on this point, let me know if you want me to
make it consistent and in which direction.

[arv (Not doing code reviews), 2014-12-01 21:00:24]

LGTM

[philipj_slow, 2014-12-01 21:03:11]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-12-01 21:04:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/765123002/20001

[commit-bot: I haz the power, 2014-12-01 21:39:26]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186258